Skip to content

Commit 12308b5

Browse files
authored
chore: Tidy up array pop() with subsequent re-push() (#10099)
1 parent a9edcb0 commit 12308b5

2 files changed

Lines changed: 3 additions & 6 deletions

File tree

lib/hls/hls_parser.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4798,9 +4798,8 @@ shaka.hls.HlsParser = class {
47984798
} else if (bitrates.length) {
47994799
// It applies to every segment between it and the next EXT-X-BITRATE,
48004800
// so we use the latest bitrate value
4801-
const prevBitrate = bitrates.pop();
4801+
const prevBitrate = bitrates[bitrates.length - 1];
48024802
prevBitrate.duration += reference.endTime - reference.startTime;
4803-
bitrates.push(prevBitrate);
48044803
reference.bandwidth = prevBitrate.bitrate;
48054804
}
48064805

lib/util/ts_parser.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -771,10 +771,9 @@ shaka.util.TsParser = class {
771771
if (!data) {
772772
continue;
773773
}
774-
previousPes = this.audioPes_.pop();
774+
previousPes = this.audioPes_[this.audioPes_.length - 1];
775775
previousPes.data =
776776
shaka.util.Uint8ArrayUtils.concat(previousPes.data, data);
777-
this.audioPes_.push(previousPes);
778777
}
779778
}
780779
}
@@ -806,10 +805,9 @@ shaka.util.TsParser = class {
806805
if (!data) {
807806
continue;
808807
}
809-
previousPes = this.videoPes_.pop();
808+
previousPes = this.videoPes_[this.videoPes_.length - 1];
810809
previousPes.data =
811810
shaka.util.Uint8ArrayUtils.concat(previousPes.data, data);
812-
this.videoPes_.push(previousPes);
813811
}
814812
}
815813
if (naluProcessing) {

0 commit comments

Comments
 (0)