Skip to content

Commit aa82e21

Browse files
absidueavelad
authored andcommitted
chore: Tidy up array pop() with subsequent re-push() (#10099)
1 parent c272f9a commit aa82e21

2 files changed

Lines changed: 3 additions & 6 deletions

File tree

lib/hls/hls_parser.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4399,9 +4399,8 @@ shaka.hls.HlsParser = class {
43994399
} else if (bitrates.length) {
44004400
// It applies to every segment between it and the next EXT-X-BITRATE,
44014401
// so we use the latest bitrate value
4402-
const prevBitrate = bitrates.pop();
4402+
const prevBitrate = bitrates[bitrates.length - 1];
44034403
prevBitrate.duration += reference.endTime - reference.startTime;
4404-
bitrates.push(prevBitrate);
44054404
reference.bandwidth = prevBitrate.bitrate;
44064405
}
44074406

lib/util/ts_parser.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -794,10 +794,9 @@ shaka.util.TsParser = class {
794794
if (!data) {
795795
continue;
796796
}
797-
previousPes = this.audioPes_.pop();
797+
previousPes = this.audioPes_[this.audioPes_.length - 1];
798798
previousPes.data =
799799
shaka.util.Uint8ArrayUtils.concat(previousPes.data, data);
800-
this.audioPes_.push(previousPes);
801800
}
802801
}
803802
}
@@ -829,10 +828,9 @@ shaka.util.TsParser = class {
829828
if (!data) {
830829
continue;
831830
}
832-
previousPes = this.videoPes_.pop();
831+
previousPes = this.videoPes_[this.videoPes_.length - 1];
833832
previousPes.data =
834833
shaka.util.Uint8ArrayUtils.concat(previousPes.data, data);
835-
this.videoPes_.push(previousPes);
836834
}
837835
}
838836
if (naluProcessing) {

0 commit comments

Comments
 (0)