Skip to content

Commit eb94e6f

Browse files
authored
fix: Fix duplicate error code 4058 (#10372)
The error code number 4058 was assigned to both MSF_VOD_CONTENT_NOT_SUPPORTED and MSF_CATALOG_TIMEOUT. This moves MSF_CATALOG_TIMEOUT to the next available code in that group, 4064. This was surfaced during an error code analysis on Shaka source as part of a Cast analytics effort.
1 parent 1d28ee2 commit eb94e6f

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

lib/util/error.js

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -843,11 +843,6 @@ shaka.util.Error.Code = {
843843
*/
844844
'MSF_VOD_CONTENT_NOT_SUPPORTED': 4058,
845845

846-
/**
847-
* A catalog request timed out.
848-
*/
849-
'MSF_CATALOG_TIMEOUT': 4058,
850-
851846
/**
852847
* AES-256-GCM EXT-X-KEY must not include an IV attribute.
853848
*/
@@ -880,6 +875,14 @@ shaka.util.Error.Code = {
880875
*/
881876
'DASH_UNSUPPORTED_ESSENTIAL_PROPERTY': 4063,
882877

878+
/**
879+
* A catalog request timed out.
880+
*
881+
* Formerly assigned to 4058, which was a duplicate of
882+
* MSF_VOD_CONTENT_NOT_SUPPORTED.
883+
*/
884+
'MSF_CATALOG_TIMEOUT': 4064,
885+
883886
// RETIRED: 'INCONSISTENT_BUFFER_STATE': 5000,
884887
// RETIRED: 'INVALID_SEGMENT_INDEX': 5001,
885888
// RETIRED: 'SEGMENT_DOES_NOT_EXIST': 5002,
@@ -1123,7 +1126,7 @@ shaka.util.Error.Code = {
11231126
'CAST_RECEIVER_APP_UNAVAILABLE': 8006,
11241127

11251128

1126-
// RETIRED: CAST_RECEIVER_APP_ID_MISSING': 8007,
1129+
// RETIRED: 'CAST_RECEIVER_APP_ID_MISSING': 8007,
11271130

11281131

11291132
/**

0 commit comments

Comments
 (0)