Skip to content

Unable To Switch To English Audio Track With Descriptive Role #8248

@agajassi

Description

@agajassi

Have you read the FAQ and checked for duplicate open issues?
Yes. I could not find a duplicate.

If the problem is related to FairPlay, have you read the tutorial?

What version of Shaka Player are you using?

Can you reproduce the issue with our latest release version?
Yes with 4.13.8

Can you reproduce the issue with the latest code from main?
Yes I can

Are you using the demo app or your own custom app?
Can reproduce with both.

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
This is not a browser specific, but I was on MacOS Chrome browser.

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?

I cannot share it here.. but I can email if necessary.

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

Default config

What did you do?

Started playing my manifest url that has multiple audio tracks.. First audio track is English with role main and the second track is also English but with description role. The other tracks are foreign languages such as Spanish or Portuguese.

After playback started I switched audio track to English description using selectAudioLanguage('en', 'description'). It did switch to the track I want, but after several seconds it switched back to main. It allows me to switch to description` track but does not persist.

What did you expect to happen?
I expected it to continue playing with English description track.

What actually happened?

In a nutshell, player appears to ignore the role parameter of selectAudioLanguage API. ExampleBasedCriteria in variant selection does not honor audio track role. It is very important for us to be able to switch to the same audio language but with different role.

It looks like this bug was first introduced in 4.11.12 version. Prior to that version I cannot reproduce the issue.

Are you planning to send a PR to fix it?
Sure I can do that. I was planning to remove ExampleBasedCriteria approach in selectVariantTrack in favor of adaptationSetCriteriaFactory with PreferenceBasedCriteria.

Metadata

Metadata

Assignees

Labels

priority: P2Smaller impact or easy workaroundtype: bugSomething isn't working correctly

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions