Out of memory issue on Sky Q on Shaka 4.14.0+

[ShanePhelan]

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

No

What version of Shaka Player are you using?

4.14.0

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Custom app

If custom app, can you reproduce the issue using our demo app?
No

What browser and OS are you using?
QTWebEngine

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Sky Q

What are the manifest and license server URIs?

Not required just yet

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

{"drm":{"servers":{"com.widevine.alpha":"..."},"advanced":{"com.widevine.alpha":{"distinctiveIdentifierRequired":false,"persistentStateRequired":false,"videoRobustness":["SW_SECURE_CRYPTO"],"audioRobustness":["SW_SECURE_CRYPTO"],"sessionType":"","serverCertificateUri":"","individualizationServer":""}}},"manifest":{"defaultPresentationDelay":18,"dash":{"ignoreMinBufferTime":true}},"streaming":{"retryParameters":{"maxAttempts":3,"baseDelay":2000},"rebufferingGoal":8,"bufferingGoal":18,"bufferBehind":10},"mediaSource":{"dispatchAllEmsgBoxes":true},"abr":{"restrictions":{"maxHeight":576,"minBandwidth":1000000,"maxBandwidth":1800000}}}

What did you do?

We restrict simulcast streams to the 576 rendition for startup. This is to allow the stream to start a bit quicker.

Once the stream starts, we then remove the restriction, and the player can switch up to the 720 and 1080 renditions.

When testing Shaka 4.16.1, we've noticed that our app crashes (black screen, app unresponsive) after about 24/30 seconds of playback. The crash only happens once the 576 height restriction is removed. We can also get the app to crash if we don't invoke the startup restriction at all (ie allow the 720/1080 rendition to be used straight away)

We also ran Shaka 4.16.1 on our small lightweight player test app and the streams played out fine for a couple of hours

So a combination of our React based app, the 720/1080 renditions, plus Shaka 4.16.1 is causing the app to crash.

Sky have confirmed it's an OS out-of-memory issue and that is why the app gets killed by the Sky OS

Note: Shaka versions upto 4.13.25 playback fine. It's only from Shaka 4.14.0 where this crash happens.

Alot of changes went into 4.14.0 so it's hard for us to pinpoint what commit is causing it.

We can help narrow it down if someone could suggest which commits are likely to have caused the issue

What did you expect to happen?
The stream should playback without causing the app to crash

What actually happened?

The app crashes once the player starts downloading the 1080 rendition

Are you planning to send a PR to fix it?
No, but we can help narrow it down if someone could suggest which commits are likely to have caused the issue

[matvp91]

Would you be able to dump memory snapshots on the device?

[ShanePhelan]

Thanks @matvp91 I'm waiting on Sky to provide memory snapshots

[matvp91]

@ShanePhelan a hunch but could you set dispatchAllEmsgBoxes to false and see if there's any difference?

[shaka-bot]

Closing due to inactivity. If this is still an issue for you or if you have further questions, the OP can ask shaka-bot to reopen it by including @shaka-bot reopen in a comment.

[ShanePhelan]

Apologies, can this be reopened please.

I've attached all we've been given from Sky.

@matvp91 we removed dispatchAllEmsgBoxes completely and still had the same issue.

[matvp91]

Is there the possibility to compare heap snapshots? Makes me wonder what exactly is left in memory.

Could you also run the same test with the latest version, or main? There's been some effort lately in memory pressure.

Can you provide us with the manifest URL?

[pahonski]

@ShanePhelan, did you find a solution in the end?