-
Notifications
You must be signed in to change notification settings - Fork 380
Open
Description
Background
During the Babel to SWC migration (#666), we discovered several files with formatting inconsistencies that don't match the project's Prettier and ESLint configurations.
Files with Formatting Issues
The following files have formatting that doesn't match current linter rules:
client/app/packs/server-bundle.js- Uses double quotes instead of single quotesconfig/webpack/clientWebpackConfig.js- Missing proper file endingconfig/webpack/commonWebpackConfig.js- Inconsistent line wrapping and trailing commasconfig/webpack/development.js- Extra blank linesclient/app/bundles/comments/rescript/RescriptShow/ror_components/RescriptShow.jsx- ReScript-generated file with double quotes
Proposed Solution
Create a focused PR to:
- Run
yarn lint --fixacross the entire codebase - Fix any linting errors that can't be auto-fixed
- Ensure all files conform to
.prettierrc.ymland.eslintrcrules - Consider updating
.prettierignoreto exclude ReScript-generated files if needed
Why Separate PR?
- Keeps PRs focused on specific changes
- Makes code review easier
- Separates functional changes from formatting changes
- Establishes a clean baseline for future linting
Acceptance Criteria
- All files pass
yarn lintwithout warnings - All files pass
bundle exec rubocopwithout offenses - Formatting is consistent across the codebase
- CI linting checks pass
Metadata
Metadata
Assignees
Labels
No labels