Skip to content

Commit 86db2c9

Browse files
authored
Fix Claude Code agent format and follow subagent best practices
- Add required YAML frontmatter (name, description) to pr-testing-agent.md - Move pr-testing-guide.md to .claude/docs/ (documentation, not an agent) - Replace markdown links with plain file paths per subagent best practices - Add "Additional Context" section pointing to files the agent can read - Update cross-references for new file locations - Remove reference to non-existent code-reviewer agent The agent was originally created as documentation (PR #2109) and later moved to .claude/agents/ (PR #2112) without the required frontmatter. This aligns it with Claude Code subagent specifications. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
1 parent 03673a4 commit 86db2c9

File tree

2 files changed

+22
-20
lines changed

2 files changed

+22
-20
lines changed

.claude/agents/pr-testing-agent.md

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,22 @@
1+
---
2+
name: pr-testing-agent
3+
description: Validates PR testing before merge. Use when creating PRs, investigating CI failures, or verifying testing claims. Adopts a skeptical stance - assumes tests have gaps and manual verification is required.
4+
---
5+
16
# PR Testing Agent
27

38
**Role:** Specialized agent for comprehensive PR testing validation before merge.
49

510
**Core Principle:** Be deeply suspicious of claims that tests passed unless you have concrete evidence. Assume automated tests have gaps. Manual testing is often required.
611

7-
## Quick Reference
12+
## Additional Context
813

9-
**See Also:**
14+
When you need more details, use the Read tool to examine:
1015

11-
- **[PR Testing Guide](pr-testing-guide.md)** - How to use this agent with Claude Code
12-
- [Testing Build Scripts](../docs/testing-build-scripts.md) - Build/package testing requirements
13-
- [CI Config Switching](../../SWITCHING_CI_CONFIGS.md) - Testing minimum vs latest dependencies
14-
- [Local Testing Issues](../../react_on_rails/spec/dummy/TESTING_LOCALLY.md) - Environment-specific testing issues
15-
- [Master Health Monitoring](../docs/master-health-monitoring.md) - Post-merge CI monitoring
16-
- [CLAUDE.md](../../CLAUDE.md) - Full development guide with CI debugging
16+
- `.claude/docs/testing-build-scripts.md` - Build/package testing requirements
17+
- `.claude/docs/master-health-monitoring.md` - Post-merge CI monitoring
18+
- `SWITCHING_CI_CONFIGS.md` - CI config switching guide
19+
- `react_on_rails/spec/dummy/TESTING_LOCALLY.md` - Environment-specific testing issues
1720

1821
## Agent Behavior
1922

@@ -146,7 +149,7 @@ bundle exec rake
146149

147150
**Why this matters:**
148151

149-
- See [../docs/testing-build-scripts.md](../docs/testing-build-scripts.md) for real examples of silent failures
152+
- See `.claude/docs/testing-build-scripts.md` for real examples of silent failures
150153
- Build scripts run during `npm install`, `yalc publish`, and package installation
151154
- Failures are often SILENT in CI but break users completely
152155

@@ -211,7 +214,7 @@ gh run list --workflow="Integration Tests" --branch <pr-branch> --limit 10 --jso
211214
# Key question: Did MY commits break it, or was it already broken?
212215
```
213216

214-
**See [../docs/testing-build-scripts.md](../docs/testing-build-scripts.md) "Before You Start: Check CI Status"**
217+
**See `.claude/docs/testing-build-scripts.md` "Before You Start: Check CI Status"**
215218

216219
**Reproduce failures locally:**
217220

@@ -231,7 +234,7 @@ bin/ci-rerun-failures
231234
pbpaste | bin/ci-run-failed-specs
232235
```
233236

234-
**See [../../SWITCHING_CI_CONFIGS.md](../../SWITCHING_CI_CONFIGS.md) for full details**
237+
**See `SWITCHING_CI_CONFIGS.md` for full details**
235238

236239
### 6. Generator Changes
237240

@@ -381,7 +384,7 @@ cd react_on_rails/spec/dummy
381384
bundle exec rspec spec/system/integration_spec.rb
382385
```
383386

384-
**See [../../react_on_rails/spec/dummy/TESTING_LOCALLY.md](../../react_on_rails/spec/dummy/TESTING_LOCALLY.md) for details**
387+
**See `react_on_rails/spec/dummy/TESTING_LOCALLY.md` for details**
385388

386389
## Success Criteria: Well-Tested PR
387390

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# PR Testing Guide
22

3-
**Companion to:** [PR Testing Agent](pr-testing-agent.md)
3+
**Companion to:** [PR Testing Agent](../agents/pr-testing-agent.md)
44

55
This guide shows you **how to use** the PR Testing Agent with Claude Code, including workflows, checklists, templates, and real-world examples.
66

@@ -17,8 +17,8 @@ This guide shows you **how to use** the PR Testing Agent with Claude Code, inclu
1717

1818
**Related Documentation:**
1919

20-
- **[PR Testing Agent](pr-testing-agent.md)** - Core agent behavior and requirements
21-
- [Testing Build Scripts](../docs/testing-build-scripts.md) - Build/package testing requirements
20+
- **[PR Testing Agent](../agents/pr-testing-agent.md)** - Core agent behavior and requirements
21+
- [Testing Build Scripts](testing-build-scripts.md) - Build/package testing requirements
2222
- [CI Config Switching](../../SWITCHING_CI_CONFIGS.md) - Testing minimum vs latest dependencies
2323
- [CLAUDE.md](../../CLAUDE.md) - Full development guide
2424

@@ -68,7 +68,7 @@ This guide shows you **how to use** the PR Testing Agent with Claude Code, inclu
6868
**The easiest way to use this agent with Claude Code is to explicitly reference it in your prompts:**
6969

7070
```
71-
"Use the PR Testing Agent from .claude/agents/pr-testing-agent.md to validate my testing"
71+
"Validate my testing using the pr-testing-agent"
7272
7373
"I changed package.json. According to PR Testing Agent Section 3, what testing is required?"
7474
@@ -334,7 +334,7 @@ pbpaste | bin/ci-run-failed-specs
334334

335335
**The PR Testing Agent guidelines are automatically available when:**
336336

337-
- You reference `.claude/agents/pr-testing-agent.md` in prompts
337+
- You ask about PR testing validation or readiness to merge
338338
- You mention "PR Testing Agent" or "testing checklist"
339339
- You ask about testing requirements for specific file types
340340
- CLAUDE.md is loaded (which references this documentation)
@@ -348,7 +348,6 @@ pbpaste | bin/ci-run-failed-specs
348348
**This agent complements but does not replace:**
349349

350350
- Standard code review for logic, design, and maintainability
351-
- The `code-reviewer` agent (focuses on code quality, security)
352351
- CI automated checks (provides guidance when they fail)
353352

354353
**This agent specializes in:**
@@ -686,8 +685,8 @@ gh pr view --json statusCheckRollup
686685

687686
**Reference documentation:**
688687

689-
- Testing build scripts: [../docs/testing-build-scripts.md](../docs/testing-build-scripts.md)
688+
- Testing build scripts: [testing-build-scripts.md](testing-build-scripts.md)
690689
- CI debugging: [CLAUDE.md](../../CLAUDE.md) "Replicating CI Failures Locally"
691690
- Config switching: [SWITCHING_CI_CONFIGS.md](../../SWITCHING_CI_CONFIGS.md)
692691
- Local testing issues: [react_on_rails/spec/dummy/TESTING_LOCALLY.md](../../react_on_rails/spec/dummy/TESTING_LOCALLY.md)
693-
- Master health: [../docs/master-health-monitoring.md](../docs/master-health-monitoring.md)
692+
- Master health: [master-health-monitoring.md](master-health-monitoring.md)

0 commit comments

Comments
 (0)