[chore][pkg/ottl] run make modernize (open-telemetry#44621)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Run the `make modernize` tool.

https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize

This is part of the process to enable the
[modernize](open-telemetry#44199)
linter in CI.

There are no changes in the component behaviour.

Signed-off-by: Paulo Dias <[email protected]>

Author: paulojmdias

pkg/ottl/ottlfuncs/func_parse_severity.go

@@ -7,6 +7,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"slices"
 
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl"
 )
@@ -145,10 +146,8 @@ type valueRange struct {
 func (c *criteria) evaluate(value any) (bool, error) {
 	switch v := value.(type) {
 	case string:
-		for _, eq := range c.Equals {
-			if v == eq {
-				return true, nil
-			}
+		if slices.Contains(c.Equals, v) {
+			return true, nil
 		}
 		return false, nil
 	case int64:

pkg/ottl/performance_bench_test.go

@@ -328,7 +328,7 @@ func BenchmarkConditionSequenceEvalMetrics(b *testing.B) {
 
 func buildMetricStatements(count int) []string {
 	result := make([]string, 0, count)
-	for i := 0; i < count; i++ {
+	for i := range count {
 		switch i % 5 {
 		case 0:
 			result = append(result, fmt.Sprintf(`set(metric.metadata["copy_source_%[1]d"], metric.metadata["source_%[1]d"])`, i))
@@ -347,7 +347,7 @@ func buildMetricStatements(count int) []string {
 
 func buildMetricConditions(count int) []string {
 	result := make([]string, 0, count)
-	for i := 0; i < count; i++ {
+	for i := range count {
 		switch i % 5 {
 		case 0:
 			result = append(result, "metric.type == METRIC_DATA_TYPE_SUM")
@@ -400,7 +400,7 @@ func newBenchmarkMetricContext(attributeCount int) ottlmetric.TransformContext {
 	dp.Attributes().PutStr("method", "GET")
 	dp.SetIntValue(4200)
 
-	for i := 0; i < attributeCount; i++ {
+	for i := range attributeCount {
 		metric.Metadata().PutStr(fmt.Sprintf("source_%d", i), fmt.Sprintf("value_%d", i))
 		dp.Attributes().PutStr(fmt.Sprintf("label_%d", i), fmt.Sprintf("value_%d", i))
 	}
@@ -410,7 +410,7 @@ func newBenchmarkMetricContext(attributeCount int) ottlmetric.TransformContext {
 
 func buildLogStatements(count int) []string {
 	result := make([]string, 0, count)
-	for i := 0; i < count; i++ {
+	for i := range count {
 		switch i % 5 {
 		case 0:
 			result = append(result, fmt.Sprintf(`set(log.attributes["conditional_copy_%[1]d"], log.attributes["source_%[1]d"]) where log.attributes["severity_text"] == "error"`, i))
@@ -429,7 +429,7 @@ func buildLogStatements(count int) []string {
 
 func buildSpanStatements(count int) []string {
 	result := make([]string, 0, count)
-	for i := 0; i < count; i++ {
+	for i := range count {
 		switch i % 4 {
 		case 0:
 			result = append(result, fmt.Sprintf(`set(span.attributes["span_copy_%[1]d"], span.attributes["source_%[1]d"]) where span.kind.string == "SPAN_KIND_CLIENT"`, i))
@@ -446,7 +446,7 @@ func buildSpanStatements(count int) []string {
 
 func buildLogConditions(count int) []string {
 	result := make([]string, 0, count)
-	for i := 0; i < count; i++ {
+	for i := range count {
 		switch i % 3 {
 		case 0:
 			result = append(result, fmt.Sprintf(`log.attributes["source_%[1]d"] != nil`, i))
@@ -481,7 +481,7 @@ func newBenchmarkLogContext(attributeCount int) ottllog.TransformContext {
 	tags.AppendEmpty().SetStr("prod")
 	tags.AppendEmpty().SetStr("critical")
 
-	for i := 0; i < attributeCount; i++ {
+	for i := range attributeCount {
 		logRecord.Attributes().PutStr(fmt.Sprintf("source_%d", i), fmt.Sprintf("value_%d", i))
 	}
 
@@ -513,7 +513,7 @@ func newBenchmarkSpanContext(attributeCount int) ottlspan.TransformContext {
 	span.Status().SetCode(ptrace.StatusCodeOk)
 	span.Status().SetMessage("ok")
 
-	for i := 0; i < attributeCount; i++ {
+	for i := range attributeCount {
 		span.Attributes().PutStr(fmt.Sprintf("source_%d", i), fmt.Sprintf("span_value_%d", i))
 	}
 
@@ -619,7 +619,7 @@ func newSliceContextWithPrimitiveArr(arrSize int) ottllog.TransformContext {
 
 	arr := lr.Attributes().PutEmptySlice("arr")
 	arr.EnsureCapacity(arrSize)
-	for i := 0; i < arrSize; i++ {
+	for i := range arrSize {
 		arr.AppendEmpty().SetStr("v_" + strconv.Itoa(i))
 	}
 
@@ -637,7 +637,7 @@ func newSliceContextWithMapArr(arrSize int) ottllog.TransformContext {
 
 	arr := lr.Attributes().PutEmptySlice("arr")
 	arr.EnsureCapacity(arrSize)
-	for i := 0; i < arrSize; i++ {
+	for i := range arrSize {
 		elem := arr.AppendEmpty()
 		m := elem.SetEmptyMap()
 		m.PutStr("id", "item_"+strconv.Itoa(i))