BadState on autoReconnect

[ygorrrteles]

The package is trying to execute the .fire of the eventBus even after the closure has been executed, would it be possible to add a validation if the clientEventBus has already been closed and if it is different from null?

I/flutter (11479): ----------------FIREBASE CRASHLYTICS----------------
I/flutter (11479): Bad state: Cannot add new events after calling close
I/flutter (11479): #0      _BroadcastStreamController.add (dart:async/broadcast_stream_controller.dart:256:24)
I/flutter (11479): #1      EventBus.fire (package:event_bus/event_bus.dart:61:22)
I/flutter (11479): #2      MqttConnectionHandlerBase.autoReconnect (package:mqtt_client/src/connectionhandling/mqtt_client_mqtt_connection_handler_base.dart:160:23)
I/flutter (11479): <asynchronous suspension>
I/flutter (11479): ----------------------------------------------------

[shamblett]

Interesting I'll take a look.

[shamblett]

It looks as though this isn't a 'guarded fire', it just calls fire as you have spotted. I some parts of the package it does check to see if the event bus is closed before firing.

In this case however the autoreconnect sequence has successfully reconnected so the event bus should be OK here, if its not then another failure should be hit further on than this so I can't explain whuyyou are seeing this.

In any case I'll just update the client to guard this call, if the event bus is closed this is just logged and the client will continue.

Hopfully re publish in the next few days.

[ygorrrteles]

Can you provide an example of a correct package implementation? This also includes a disconnection scenario if the application is minimized.

I'll use it to update my implementation.

[shamblett]

From what you are saying I think you are OK, if you are disconnecting when the app is minimsed and reconnecting again when it comes back this is OK. You are just a bit unlucky in that you have autoreconnect set, it kicked in before you minimised, then you disconnected then one of its closures was called, in this case when connection was re established.

Since you are already disconnected you have no further processing to do so there should be no further effects.

The only examples I have are those in the examples directory of the repo. I don't use flutter, this is a pure Dart library so it has no concept of being minimised.

OK, I've updated the package and re published it at version 10.11.1, so how you get on with this.

[ygor-coelho]

Hey friend, after this fix, the same error started to appear on another line. I forked your project to test the solution and wanted to ask for an update from you as well. Below I'll put the changes I made to the fork.

[shamblett]

OK, please raise a PR with your proposed changes in, thanks.