Skip to content

Commit 0e63e45

Browse files
gomesalexandrecjthompson0xdef1cafe
authored
feat: change portfolio selectors arity (#1635)
* feat: change portfolio selectors arity Co-authored-by: Chris Thompson <[email protected]> Co-authored-by: 0xdef1cafe <[email protected]>
1 parent d24287b commit 0e63e45

File tree

31 files changed

+265
-282
lines changed

31 files changed

+265
-282
lines changed

src/components/AccountAssets/AccountAssets.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ type AccountAssetsProps = {
1717

1818
export const AccountAssets = ({ assetId, accountId }: AccountAssetsProps) => {
1919
const assetIds = useAppSelector(state =>
20-
selectPortfolioAssetIdsByAccountIdExcludeFeeAsset(state, accountId),
20+
selectPortfolioAssetIdsByAccountIdExcludeFeeAsset(state, { accountId }),
2121
)
2222
const asset = useAppSelector(state => selectAssetById(state, assetId))
2323

src/components/AccountRow/AccountRow.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ export const AccountRow = ({ allocationValue, assetId, ...rest }: AccountRowArgs
2828
const asset = useAppSelector(state => selectAssetById(state, assetId))
2929
const marketData = useAppSelector(state => selectMarketDataById(state, assetId))
3030
const cryptoValue = useAppSelector(state =>
31-
selectPortfolioCryptoHumanBalanceByAssetId(state, assetId),
31+
selectPortfolioCryptoHumanBalanceByAssetId(state, { assetId }),
3232
)
33-
const fiatValue = useAppSelector(state => selectPortfolioFiatBalanceByAssetId(state, assetId))
33+
const fiatValue = useAppSelector(state => selectPortfolioFiatBalanceByAssetId(state, { assetId }))
3434

3535
if (!asset) return null // users may have assets we don't support
3636

src/components/AssetAccounts/AssetAccounts.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ type AssetAccountsProps = {
1717
export const AssetAccounts = ({ assetId, accountId }: AssetAccountsProps) => {
1818
const translate = useTranslate()
1919
const accountIds = useAppSelector(state =>
20-
selectAccountIdsByAssetIdAboveBalanceThreshold(state, assetId),
20+
selectAccountIdsByAssetIdAboveBalanceThreshold(state, { assetId }),
2121
)
2222
if ((accountIds && accountIds.length === 0) || accountId) return null
2323
return (

src/components/AssetHeader/AssetHeader.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ type AssetHeaderProps = {
2121
export const AssetHeader: React.FC<AssetHeaderProps> = ({ assetId, accountId }) => {
2222
const asset = useAppSelector(state => selectAssetById(state, assetId))
2323
const chainId = asset.chainId
24-
const accountIds = useAppSelector(state => selectAccountIdsByAssetId(state, assetId))
24+
const accountIds = useAppSelector(state => selectAccountIdsByAssetId(state, { assetId }))
2525
const singleAccount = accountIds && accountIds.length === 1 ? accountIds[0] : undefined
2626
const { name, symbol, icon } = asset || {}
2727

src/components/SelectAssets/SelectAccount.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export const SelectAccount = ({ onClick }: SelectAccountProps) => {
2525
const translate = useTranslate()
2626
const history = useHistory()
2727
const accountIds = useAppSelector(state =>
28-
selectAccountIdsByAssetId(state, location.state.assetId),
28+
selectAccountIdsByAssetId(state, { assetId: location.state.assetId }),
2929
)
3030
const asset = useAppSelector(state => selectAssetById(state, location.state.assetId))
3131
return (

src/components/Trade/TradeInput.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export const TradeInput = ({ history }: RouterProps) => {
6363
} = useWallet()
6464

6565
const sellAssetBalance = useAppSelector(state =>
66-
selectPortfolioCryptoHumanBalanceByAssetId(state, sellAsset?.currency?.assetId),
66+
selectPortfolioCryptoHumanBalanceByAssetId(state, { assetId: sellAsset?.currency?.assetId }),
6767
)
6868
const hasValidTradeBalance = bnOrZero(sellAssetBalance).gte(bnOrZero(sellAsset?.amount))
6969
const hasValidBalance = bnOrZero(sellAssetBalance).gt(0)
@@ -74,7 +74,9 @@ export const TradeInput = ({ history }: RouterProps) => {
7474
: selectAssetById(state, 'eip155:1/slip44:60'),
7575
)
7676
const feeAssetBalance = useAppSelector(state =>
77-
feeAsset ? selectPortfolioCryptoHumanBalanceByAssetId(state, feeAsset?.assetId) : null,
77+
feeAsset
78+
? selectPortfolioCryptoHumanBalanceByAssetId(state, { assetId: feeAsset?.assetId })
79+
: null,
7880
)
7981

8082
// when trading from ETH, the value of TX in ETH is deducted

src/components/Trade/hooks/useSwapper/useSwapper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ export const useSwapper = () => {
117117
}, [])
118118

119119
const sellAssetBalance = useAppSelector(state =>
120-
selectPortfolioCryptoBalanceByAssetId(state, sellAsset?.currency?.assetId),
120+
selectPortfolioCryptoBalanceByAssetId(state, { assetId: sellAsset?.currency?.assetId }),
121121
)
122122

123123
const getSendMaxAmount = async ({

src/components/TransactionHistory/AssetTransactionHistory.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export const AssetTransactionHistory: React.FC<AssetTransactionHistoryProps> = (
3333

3434
const asset = useAppSelector(state => selectAssetById(state, assetId))
3535
const chainId = asset.chainId
36-
const accountIds = useAppSelector(state => selectAccountIdsByAssetId(state, assetId))
36+
const accountIds = useAppSelector(state => selectAccountIdsByAssetId(state, { assetId }))
3737
const filter = useMemo(
3838
// if we are passed an accountId, we're on an asset account page, use that specifically.
3939
// otherwise, we're on an asset page, use all accountIds related to this asset

src/context/TransactionsProvider/TransactionsProvider.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,9 @@ export const TransactionsProvider = ({ children }: TransactionsProviderProps): J
123123
msg => {
124124
const caip10 = `${msg.caip2}:${msg.address}`
125125
const state = store.getState()
126-
const accountId = selectAccountIdByAddress(state, caip10)
126+
const accountId = selectAccountIdByAddress(state, {
127+
accountSpecifier: caip10,
128+
})
127129
dispatch(
128130
txHistory.actions.onMessage({
129131
message: { ...msg, accountType },

src/features/defi/providers/foxy/components/FoxyManager/Deposit/components/Deposit.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export const Deposit = ({ api, apy, getDepositGasEstimate }: FoxyDepositProps) =
4343
if (!marketData) appDispatch(marketApi.endpoints.findByCaip19.initiate(assetId))
4444

4545
// user info
46-
const balance = useAppSelector(state => selectPortfolioCryptoBalanceByAssetId(state, assetId))
46+
const balance = useAppSelector(state => selectPortfolioCryptoBalanceByAssetId(state, { assetId }))
4747

4848
// notify
4949
const toast = useToast()

0 commit comments

Comments
 (0)