Would you accept a PR to search inside archives?

[mqudsi]

Hello,

Would you be open to accepting a PR that searched within archives (starting with .zip files)?

This could be easily implemented using the zip crate, which would introduce dependencies on crc32fast, crossbeam-utils (already a crossbeam dependency in fd's own), indexmap, and memchr. It can obviously be gated behind a feature flag, but you'd have to figure out whether you'd want it supported by default or not (with the primary difference being how it ends up packaged by distros).

[tmccombs]

What would be the benefit of that over something like

unzip -l  file.zip| grep ...

fd's parallelization wouldn't help that much, since the archive file has to be read in series. And the ignore functionality probably isn't as useful for inspecting archives.

Also, if we added support for searching zip files, we would probably also want support for tarballs (with various kinds of compression). And possibly other archive formats, such as 7zip as well.

[tavianator]

I think the benefit would be if you don't know exactly which .zip file contains the file you're looking for. But I'm not sure that potential benefit outweighs the added complexity to fd.

[mqudsi]

Yes, as @tavianator says, it would be to search for a file you know exists in a directory of uncompressed and compressed files, where the file could be in either. In my case, the Downloads directory.