From 561d51da93561c048ad080dbe93f7ed75b6abc99 Mon Sep 17 00:00:00 2001 From: YLTai Date: Sat, 28 Sep 2024 05:19:38 +0800 Subject: [PATCH 1/3] - Modified the GitHub Workflow's upload-artifact to correct the destination directory from 'InventoryTools' to 'InventoryToolsCN'. - Added a new option in the RightClickService to search for items on the FFXIV-CN HuijiWiki. --- .github/workflows/build.yml | 2 +- InventoryTools/Services/RightClickService.cs | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 57502133..10868fa9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -36,4 +36,4 @@ jobs: with: name: dist path: | - InventoryTools/bin/Release/InventoryTools \ No newline at end of file + InventoryTools/bin/Release/InventoryToolsCN \ No newline at end of file diff --git a/InventoryTools/Services/RightClickService.cs b/InventoryTools/Services/RightClickService.cs index 805b6fe4..bbc9be27 100644 --- a/InventoryTools/Services/RightClickService.cs +++ b/InventoryTools/Services/RightClickService.cs @@ -245,6 +245,10 @@ public List DrawMenuItems(ItemEx item, List messages, { ImGui.Text(item.NameString); ImGui.Separator(); + if (ImGui.Selectable("Open in FFXIV-CN HuijiWiki")) + { + $"https://ff14.huijiwiki.com/wiki/%E7%89%A9%E5%93%81:{item.GarlandToolsId}".OpenBrowser(); + } if (ImGui.Selectable("Open in Garland Tools")) { $"https://www.garlandtools.org/db/#item/{item.GarlandToolsId}".OpenBrowser(); From ffaa5aff506fe0cc19b9cf997e2ccdad7b85e2a5 Mon Sep 17 00:00:00 2001 From: YLTai Date: Sat, 28 Sep 2024 05:33:10 +0800 Subject: [PATCH 2/3] fix: URL concatenation issue when querying items in Huijiwiki. --- InventoryTools/Services/RightClickService.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/InventoryTools/Services/RightClickService.cs b/InventoryTools/Services/RightClickService.cs index bbc9be27..d7109e42 100644 --- a/InventoryTools/Services/RightClickService.cs +++ b/InventoryTools/Services/RightClickService.cs @@ -247,7 +247,7 @@ public List DrawMenuItems(ItemEx item, List messages, ImGui.Separator(); if (ImGui.Selectable("Open in FFXIV-CN HuijiWiki")) { - $"https://ff14.huijiwiki.com/wiki/%E7%89%A9%E5%93%81:{item.GarlandToolsId}".OpenBrowser(); + $"https://ff14.huijiwiki.com/wiki/%E7%89%A9%E5%93%81:{HttpUtility.UrlEncode(name)}".OpenBrowser(); } if (ImGui.Selectable("Open in Garland Tools")) { From 7ecf24c54d5022df8368ab927302ea485d200046 Mon Sep 17 00:00:00 2001 From: YLTai Date: Sat, 28 Sep 2024 05:41:24 +0800 Subject: [PATCH 3/3] fix: URL concatenation issue --- InventoryTools/Services/RightClickService.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/InventoryTools/Services/RightClickService.cs b/InventoryTools/Services/RightClickService.cs index d7109e42..bd523e2b 100644 --- a/InventoryTools/Services/RightClickService.cs +++ b/InventoryTools/Services/RightClickService.cs @@ -247,7 +247,7 @@ public List DrawMenuItems(ItemEx item, List messages, ImGui.Separator(); if (ImGui.Selectable("Open in FFXIV-CN HuijiWiki")) { - $"https://ff14.huijiwiki.com/wiki/%E7%89%A9%E5%93%81:{HttpUtility.UrlEncode(name)}".OpenBrowser(); + $"https://ff14.huijiwiki.com/wiki/%E7%89%A9%E5%93%81:{HttpUtility.UrlEncode(item.NameString)}".OpenBrowser(); } if (ImGui.Selectable("Open in Garland Tools")) {