Can you disable images using image_size="false" ?

[billerickson]

I wanted just a bulleted list, no featured images.

[display-posts-remote image_size="false"]

Still had images. It looks like $atts['image_size'] isn't converted from the string "false" to the boolean. And even if it is, the following conditionals don't check it, only if $post->has_featured_media().

I changed the image markup section to this so I could disable images:

				if( $atts['image_size'] && false !== filter_var( $atts['image_size'], FILTER_VALIDATE_BOOLEAN ) ) {

					if ( $post->has_post_thumbnail() && $atts['include_link'] ) {

						$image = '<a class="image" href="' . esc_url( $post->get_permalink() ) . '">' . $post->get_the_post_thumbnail( $atts['image_size'], $imageAttributes ) . '</a> ';

					} elseif ( $post->has_post_thumbnail() ) {

						$image = '<span class="image">' . $post->get_the_post_thumbnail( $atts['image_size'], $imageAttributes ) . '</span> ';

					} elseif ( $post->has_featured_media() && $atts['include_link'] ) {

						$image = '<a class="image" href="' . esc_url( $post->get_permalink() ) . '">' . $post->get_the_post_thumbnail( 'full', $imageAttributes ) . '</a> ';

					} elseif ( $post->has_featured_media() ) {

						$image = '<span class="image">' . $post->get_the_post_thumbnail( 'full', $imageAttributes ) . '</span> ';

					}

				}

[shazahm1]

Shouldn't passing image_size="" work too, didn't test ... this is same way DPS proper works, correct, but it defaults to an empty string so no image displayed by default where DPS-Remote defaults to thumbnail

anyway I only gave a real quick glance so I probably missed something.

[billerickson]

Yes, passing an empty string works for overriding the default, but the last two if statements are using $post->has_featured_media() without a check for that parameter so the image still appears.

[display-posts-remote url="https://www.billerickson.net" category_id="319" image_size=""]

Result:

[shazahm1]

ahhh, yes, indeed. can't see the forest for the trees, lol. thx!