Skip to content

Commit 2c26b34

Browse files
authored
Revert "Remove InternalsVisibleTo attributes for .NET MAUI Community … (dotnet#34047)
### Description of Change This reverts commit 8e96657. (from dotnet#33442) Context : dotnet#29321 > Revert for now because the timing doesn't line up yet. We don't have a version of the Toolkit that uses the public types so with this change, the .NET 10 preview templates (using --sample-content) using the Toolkit will break immediately. This is still not true as per the time we're discussing this, so there's no good reason to introduce those changes (from dotnet#33442) in a service release, as this is a massive breaking change. Making the version unusable for everyone using the toolkit. Not to mention that 10.0.40 has some important bug fixes related to different crashes, which makes this situation quite annoying ### Issues Fixed Fixes dotnet#34035 Fixes dotnet#34034 Fixes dotnet#34048 #### Toolkit issues related [https://github.com/CommunityToolkit/Maui/issues/3089](https://github.com/CommunityToolkit/Maui/issues/3089) [https://github.com/CommunityToolkit/Maui/issues/3092](https://github.com/CommunityToolkit/Maui/issues/3092)
1 parent 5c6da6c commit 2c26b34

4 files changed

Lines changed: 23 additions & 0 deletions

File tree

src/Controls/src/Core/Properties/AssemblyInfo.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,13 @@
5151
[assembly: InternalsVisibleTo("Microsoft.Maui.Controls.DeviceTests")]
5252
[assembly: InternalsVisibleTo("Controls.TestCases.HostApp")]
5353

54+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui")]
55+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui.Core")]
56+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui.Embedding")]
57+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui.UnitTests")]
58+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui.Markup")]
59+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui.Markup.UnitTests")]
60+
5461
[assembly: InternalsVisibleTo("DynamicProxyGenAssembly2")]
5562

5663
[assembly: Preserve]

src/Controls/src/Xaml/Properties/AssemblyInfo.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,12 @@
1313
[assembly: InternalsVisibleTo("Microsoft.Maui.Controls.HotReload.UnitTests")]
1414
[assembly: InternalsVisibleTo("Microsoft.Maui.Controls.SourceGen")]
1515
[assembly: InternalsVisibleTo("Microsoft.Maui.Controls.Compatibility")]
16+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui")]
17+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui.Core")]
18+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui.Embedding")]
19+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui.UnitTests")]
20+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui.Markup")]
21+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui.Markup.UnitTests")]
1622
[assembly: InternalsVisibleTo("Microsoft.Maui.Controls.DeviceTests")]
1723

1824
[assembly: Preserve]

src/Core/src/Properties/AssemblyInfo.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,11 @@
3434
[assembly: InternalsVisibleTo("Core.Benchmarks")]
3535
[assembly: InternalsVisibleTo("Comet")]
3636
[assembly: InternalsVisibleTo("Comet.Tests")]
37+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui")]
38+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui.Core")]
39+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui.UnitTests")]
40+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui.Markup")]
41+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui.Markup.UnitTests")]
3742
[assembly: InternalsVisibleTo("Reloadify-emit")]
3843
[assembly: InternalsVisibleTo("Microsoft.Maui.TestUtils.DeviceTests.Runners")]
3944
[assembly: InternalsVisibleTo("Microsoft.Maui.TestUtils.DeviceTests")]

src/Essentials/src/AssemblyInfo/AssemblyInfo.shared.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@
77
[assembly: InternalsVisibleTo("EssentialsDeviceTestsUWP")]
88
[assembly: InternalsVisibleTo("EssentialsDeviceTestsShared")]
99
[assembly: InternalsVisibleTo("EssentialsDeviceTestsiOS")]
10+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui")]
11+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui.Core")]
12+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui.UnitTests")]
13+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui.Markup")]
14+
[assembly: InternalsVisibleTo("CommunityToolkit.Maui.Markup.UnitTests")]
1015
[assembly: InternalsVisibleTo("Microsoft.Maui.Controls.Core.UnitTests")]
1116
[assembly: InternalsVisibleTo("Microsoft.Maui.Controls.Xaml.UnitTests")]
1217
[assembly: InternalsVisibleTo("Microsoft.Maui.Compatibility.Core.UnitTests")]

0 commit comments

Comments
 (0)