Skip to content

Commit 6b5bab3

Browse files
Copilotjfversluis
andauthored
Avoid UITest snapshot artifact name collisions across stages (dotnet#33122)
* Initial plan * chore: plan uitest artifact fix Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com> * fix: include stage in uitest snapshot artifacts Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>
1 parent 2e139f4 commit 6b5bab3

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

eng/pipelines/common/ui-tests.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ stages:
156156
- template: ui-tests-collect-snapshot-diffs.yml
157157
parameters:
158158
platform: 'Android'
159-
artifactName: 'uitest-snapshot-results-android-$(System.JobName)-$(System.JobAttempt)'
159+
artifactName: 'uitest-snapshot-results-android-$(System.StageName)-$(System.JobName)-$(System.JobAttempt)'
160160

161161

162162
- stage: android_ui_tests_coreclr
@@ -203,7 +203,7 @@ stages:
203203
- template: ui-tests-collect-snapshot-diffs.yml
204204
parameters:
205205
platform: 'Android'
206-
artifactName: 'uitest-snapshot-results-android-$(System.JobName)-$(System.JobAttempt)'
206+
artifactName: 'uitest-snapshot-results-android-$(System.StageName)-$(System.JobName)-$(System.JobAttempt)'
207207

208208
- stage: ios_ui_tests_mono
209209
displayName: iOS UITests Mono
@@ -251,7 +251,7 @@ stages:
251251
- template: ui-tests-collect-snapshot-diffs.yml
252252
parameters:
253253
platform: 'iOS'
254-
artifactName: 'uitest-snapshot-results-ios-$(System.JobName)-$(System.JobAttempt)'
254+
artifactName: 'uitest-snapshot-results-ios-$(System.StageName)-$(System.JobName)-$(System.JobAttempt)'
255255

256256
- stage: ios_ui_tests_mono_cv2
257257
displayName: iOS UITests Mono CollectionView2
@@ -295,7 +295,7 @@ stages:
295295
- template: ui-tests-collect-snapshot-diffs.yml
296296
parameters:
297297
platform: 'iOS CV2'
298-
artifactName: 'uitest-snapshot-results-ios-cv2-$(System.JobName)-$(System.JobAttempt)'
298+
artifactName: 'uitest-snapshot-results-ios-cv2-$(System.StageName)-$(System.JobName)-$(System.JobAttempt)'
299299

300300
- stage: ios_ui_tests_mono_carv2
301301
displayName: iOS UITests Mono CarouselView2
@@ -338,7 +338,7 @@ stages:
338338
- template: ui-tests-collect-snapshot-diffs.yml
339339
parameters:
340340
platform: 'iOS CARV2'
341-
artifactName: 'uitest-snapshot-results-ios-carv2-$(System.JobName)-$(System.JobAttempt)'
341+
artifactName: 'uitest-snapshot-results-ios-carv2-$(System.StageName)-$(System.JobName)-$(System.JobAttempt)'
342342

343343
# NativeAOT iOS UI tests stage - only run when both BuildNativeAOT and RunNativeAOT parameters are true
344344
- ${{ if and(eq(parameters.BuildNativeAOT, true), eq(parameters.RunNativeAOT, true)) }}:
@@ -419,7 +419,7 @@ stages:
419419
- template: ui-tests-collect-snapshot-diffs.yml
420420
parameters:
421421
platform: 'Windows'
422-
artifactName: 'uitest-snapshot-results-windows-$(System.JobName)-$(System.JobAttempt)'
422+
artifactName: 'uitest-snapshot-results-windows-$(System.StageName)-$(System.JobName)-$(System.JobAttempt)'
423423

424424
- stage: mac_ui_tests
425425
displayName: macOS UITests
@@ -457,4 +457,4 @@ stages:
457457
- template: ui-tests-collect-snapshot-diffs.yml
458458
parameters:
459459
platform: 'Mac'
460-
artifactName: 'uitest-snapshot-results-mac-$(System.JobName)-$(System.JobAttempt)'
460+
artifactName: 'uitest-snapshot-results-mac-$(System.StageName)-$(System.JobName)-$(System.JobAttempt)'

0 commit comments

Comments
 (0)