Describe the bug
When an mkv mux command is created from an mkv object: the default track value is ignored, pymkv only checks whether the default_track value exists. So if the value exists and is false, the value is set to true in the mux command. This may be the intended behaviour but it seems counterintuitive to me. This occurs because track.default_track is a string value, not a boolean value.
To Reproduce
Here is the code from line 168 of the current version:
if track.default_track:
command.extend(['--default-track', str(track.track_id) + ':1'])
else:
command.extend(['--default-track', str(track.track_id) + ':0'])
Clearly it checks for the existence of the value but does not replicate the value in the command.
Expected behavior
That a value of 0 or False would: command.extend(['--default-track', str(track.track_id) + ':0'])
Screenshots
If applicable, add screenshots to help explain your problem.
Software (please complete the following information):
- OS: [e.g. macOS 10.14]
- MKVToolNix version [e.g. v44.0.0]
Additional context
Add any other context about the problem here.
Describe the bug
When an mkv mux command is created from an mkv object: the default track value is ignored, pymkv only checks whether the default_track value exists. So if the value exists and is false, the value is set to true in the mux command. This may be the intended behaviour but it seems counterintuitive to me. This occurs because track.default_track is a string value, not a boolean value.
To Reproduce
Here is the code from line 168 of the current version:
if track.default_track:
command.extend(['--default-track', str(track.track_id) + ':1'])
else:
command.extend(['--default-track', str(track.track_id) + ':0'])
Clearly it checks for the existence of the value but does not replicate the value in the command.
Expected behavior
That a value of 0 or False would: command.extend(['--default-track', str(track.track_id) + ':0'])
Screenshots
If applicable, add screenshots to help explain your problem.
Software (please complete the following information):
Additional context
Add any other context about the problem here.