Skip to content

Commit 177579d

Browse files
committed
Fix frontend tsconfig: exclude node_modules, add files for env.d.ts
The frontend tsconfig had "exclude": ["dist"] which overrides the parent's exclude that includes node_modules. This means **/* was matching files inside node_modules/, potentially loading conflicting type declarations that prevent the ambient declare module '*?raw' from working in CI. - Add node_modules to exclude in frontend tsconfig - Add "files" to guarantee env.d.ts (with ?raw type declaration) is loaded - Remove temporary debug step from Dagger pipeline - Bump ESLint/tsbuildinfo cache versions for fresh resolution Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent f72c8de commit 177579d

3 files changed

Lines changed: 6 additions & 13 deletions

File tree

.dagger/src/scout-for-lol-helpers.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@ export function installWorkspaceDeps(
4343
);
4444
container = container.withMountedCache(
4545
"/workspace/.eslintcache",
46-
dag.cacheVolume("scout-eslint-cache-v4"),
46+
dag.cacheVolume("scout-eslint-cache-v5"),
4747
);
4848
container = container.withMountedCache(
4949
"/workspace/.tsbuildinfo",
50-
dag.cacheVolume("tsbuildinfo-cache-v2"),
50+
dag.cacheVolume("tsbuildinfo-cache-v3"),
5151
);
5252

5353
// PHASE 1: Dependency files only (for bun install caching)
@@ -191,11 +191,11 @@ function getMountedWorkspace(
191191
);
192192
container = container.withMountedCache(
193193
"/workspace/.eslintcache",
194-
dag.cacheVolume("scout-eslint-cache-v4"),
194+
dag.cacheVolume("scout-eslint-cache-v5"),
195195
);
196196
container = container.withMountedCache(
197197
"/workspace/.tsbuildinfo",
198-
dag.cacheVolume("tsbuildinfo-cache-v2"),
198+
dag.cacheVolume("tsbuildinfo-cache-v3"),
199199
);
200200

201201
container = container

.dagger/src/scout-for-lol.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,6 @@ export async function checkScoutForLol(source: Directory): Promise<string> {
5959
// Build desktop frontend once and share
6060
const desktopFrontend = buildDesktopFrontend(pkgSource);
6161

62-
// Debug: check file state in container before running checks
63-
const debugContainer = preparedWorkspace.withWorkdir("/workspace");
64-
const debugOutput = await execOrThrow(debugContainer, [
65-
"sh", "-c",
66-
"echo '=== env.d.ts ===' && cat packages/frontend/src/env.d.ts && echo '=== astro in node_modules ===' && ls -la node_modules/astro/client.d.ts 2>&1 || echo 'astro not found' && echo '=== vite in node_modules ===' && ls -la node_modules/vite/client.d.ts 2>&1 || echo 'vite not found' && echo '=== frontend node_modules ===' && ls packages/frontend/node_modules/ 2>&1 || echo 'no frontend node_modules' && echo '=== data package resolution ===' && ls node_modules/@scout-for-lol/data/src/review/prompts/personalities/aaron.txt 2>&1 || echo 'data file not found'",
67-
]);
68-
logWithTimestamp(`Debug output:\n${debugOutput}`);
69-
7062
// Run all checks in parallel using execOrThrow to capture actual error output
7163
// (avoids opaque "GraphQL error" messages from Dagger on non-zero exit codes)
7264
const workspace = preparedWorkspace.withWorkdir("/workspace");

packages/scout-for-lol/packages/frontend/tsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
"compilerOptions": {
33
"lib": ["ESNext", "DOM", "DOM.Iterable"]
44
},
5-
"exclude": ["dist"],
5+
"exclude": ["dist", "node_modules", "**/node_modules"],
66
"extends": ["../../tsconfig.base.json"],
7+
"files": ["./src/env.d.ts"],
78
"include": [".astro/types.d.ts", "**/*", "postcss.config.ts"]
89
}

0 commit comments

Comments
 (0)