Skip to content

Commit 4d78c3e

Browse files
claudeclaude
committed
fix(root): make all 80 Bazel test targets pass locally and in CI
Rewrites Bazel test macros (eslint, typecheck, bun_test) to use sh_test with run_npm_script.sh that bypasses the sandbox and runs `bun run <script>` directly in the source tree. This fixes 76+ test failures caused by missing generated types (Prisma), PATH stripping, and node-patches in the sandbox. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent c01ea8c commit 4d78c3e

28 files changed

Lines changed: 585 additions & 301 deletions

File tree

‎.bazelrc‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,13 @@ build --workspace_status_command=tools/bazel/workspace_status.sh
1212
# Allow empty globs (many packages may or may not have .tsx, .astro, etc.)
1313
build --noincompatible_disallow_empty_glob
1414

15+
# Pass HOME through for local tests (sh_test scripts need it to find bun/mise)
16+
test --test_env=HOME
17+
1518
# Test output
1619
test --test_output=errors
1720

21+
1822
# Performance
1923
build --jobs=auto
2024
build --experimental_remote_merkle_tree_cache
@@ -36,7 +40,6 @@ common --@aspect_rules_ts//ts:default_to_tsc_transpiler
3640
# Remote cache via bazel-remote (enable after deploying bazel-remote service)
3741
# build:ci --remote_cache=http://bazel-remote.bazel-remote.svc.cluster.local:8080
3842
# build:ci --remote_upload_local_results=true
39-
build:ci --disk_cache=/tmp/bazel-disk-cache
4043
build:ci --color=yes
4144
test:ci --test_output=all
4245

‎.quality-baseline.json‎

Lines changed: 33 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,39 @@
66
"ts-suppressions": {
77
"packages/homelab/src/ha/src/util.ts": 1
88
},
9+
"ts-expect-error": {
10+
"packages/homelab/scripts/check-suppressions.ts": 1,
11+
"packages/homelab/src/ha/src/util.ts": 1,
12+
"packages/scout-for-lol/scripts/check-suppressions.ts": 1
13+
},
14+
"ts-ignore": {
15+
"packages/homelab/scripts/check-suppressions.ts": 2,
16+
"packages/scout-for-lol/scripts/check-suppressions.ts": 2
17+
},
18+
"ts-nocheck": {
19+
"packages/homelab/scripts/check-suppressions.ts": 1,
20+
"packages/homelab/src/cdk8s/generated/imports/acid.zalan.do.ts": 1,
21+
"packages/homelab/src/cdk8s/generated/imports/acme.cert-manager.io.ts": 1,
22+
"packages/homelab/src/cdk8s/generated/imports/actions.github.com.ts": 1,
23+
"packages/homelab/src/cdk8s/generated/imports/argoproj.io.ts": 1,
24+
"packages/homelab/src/cdk8s/generated/imports/cert-manager.io.ts": 1,
25+
"packages/homelab/src/cdk8s/generated/imports/deviceplugin.intel.com.ts": 1,
26+
"packages/homelab/src/cdk8s/generated/imports/fpga.intel.com.ts": 1,
27+
"packages/homelab/src/cdk8s/generated/imports/k8s.ts": 1,
28+
"packages/homelab/src/cdk8s/generated/imports/monitoring.coreos.com.ts": 1,
29+
"packages/homelab/src/cdk8s/generated/imports/monitoring.grafana.com.ts": 1,
30+
"packages/homelab/src/cdk8s/generated/imports/networking.cfargotunnel.com.ts": 1,
31+
"packages/homelab/src/cdk8s/generated/imports/nfd.k8s-sigs.io.ts": 1,
32+
"packages/homelab/src/cdk8s/generated/imports/onepassword.com.ts": 1,
33+
"packages/homelab/src/cdk8s/generated/imports/snapshot.storage.k8s.io.ts": 1,
34+
"packages/homelab/src/cdk8s/generated/imports/tailscale.com.ts": 1,
35+
"packages/homelab/src/cdk8s/generated/imports/velero.io.ts": 1,
36+
"packages/homelab/src/cdk8s/generated/imports/zfs.openebs.io.ts": 1,
37+
"packages/homelab/src/cdk8s/scripts/update-imports.ts": 2,
38+
"packages/homelab/src/ha/generate-types.ts": 2,
39+
"packages/scout-for-lol/scripts/check-suppressions.ts": 1
40+
},
941
"rust-allow": {},
1042
"prettier-ignore": {},
11-
"updated": "2026-02-18"
43+
"updated": "2026-03-01"
1244
}

‎bun.lock‎

Lines changed: 120 additions & 64 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,11 @@
2525
},
2626
"devDependencies": {
2727
"@dagger.io/dagger": "^0.19.0",
28+
"@types/bun": "^1.3.5",
29+
"@types/node": "^22.15.0",
2830
"eslint": "^9.30.1",
31+
"eslint-import-resolver-typescript": "^4.4.3",
32+
"eslint-import-resolver-typescript-bun": "^0.0.104",
2933
"lefthook": "^2.1.1",
3034
"typescript": "^5.9.3",
3135
"typescript-eslint": "^8.35.1"

‎packages/birmel/BUILD.bazel‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,16 +54,19 @@ js_binary(
5454
eslint_test(
5555
name = "lint",
5656
srcs = glob(["src/**/*.ts"]),
57+
tags = ["exclusive"],
5758
)
5859

5960
typecheck_test(
6061
name = "typecheck",
6162
srcs = glob(["src/**/*.ts"]),
63+
tags = ["exclusive"],
6264
)
6365

6466
bun_test(
6567
name = "test",
6668
srcs = glob(["src/**/*.ts"]),
69+
tags = ["exclusive"],
6770
)
6871

6972
# Container image for K8s deployment

‎packages/birmel/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"build": "true",
1717
"test": "bunx --env-file=.env.test prisma generate && bun --env-file=.env.test test",
1818
"typecheck": "prisma generate && tsc --noEmit",
19-
"lint": "eslint ."
19+
"lint": "prisma generate && eslint ."
2020
},
2121
"dependencies": {
2222
"@ai-sdk/openai": "^3.0.1",

‎packages/bun-decompile/src/lib/deminify/batch-mode.ts‎

Lines changed: 7 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@
1111
import type { DeminifyCache } from "./cache.ts";
1212
import { shouldCache, hashSource } from "./cache.ts";
1313
import { getFunctionContext } from "./call-graph.ts";
14-
import type { BatchDeminifyClient, BatchStatus } from "./batch-client.ts";
14+
import type { BatchDeminifyClient } from "./batch-client.ts";
1515
import type { OpenAIBatchClient, OpenAIBatchStatus } from "./openai-batch.ts";
16+
import { toCommonStatus, formatBatchProgress } from "./batch-utils.ts";
1617
import {
1718
saveBatchState,
1819
loadBatchState,
@@ -35,28 +36,6 @@ import type {
3536
} from "./types.ts";
3637
import type { DeminifyFileOptions } from "./deminifier.ts";
3738

38-
/** Convert OpenAI batch status to common BatchStatus */
39-
function toCommonStatus(status: OpenAIBatchStatus): BatchStatus {
40-
return {
41-
batchId: status.batchId,
42-
status: status.status === "completed" ? "ended" : "in_progress",
43-
total: status.total,
44-
succeeded: status.completed,
45-
errored: status.failed,
46-
processing: status.total - status.completed - status.failed,
47-
};
48-
}
49-
50-
/** Format batch progress for terminal display */
51-
function formatBatchProgress(
52-
completed: number,
53-
total: number,
54-
failed: number,
55-
): string {
56-
const pct = total > 0 ? Math.round((completed / total) * 100) : 0;
57-
return `\r Progress: ${String(completed)}/${String(total)} (${String(pct)}%) | Errors: ${String(failed)} `;
58-
}
59-
6039
/** Batch mode orchestrator for de-minification. Manages batch API submissions, polling, and result retrieval. */
6140
export class BatchModeProcessor {
6241
private readonly config: DeminifyConfig;
@@ -479,9 +458,11 @@ export class BatchModeProcessor {
479458
console.log("\n\nRetrieving results...");
480459

481460
// Get results using appropriate client
482-
const results = isOpenAI
483-
? await this.getOpenAIResults(batchId, contexts)
484-
: await this.getAnthropicResults(batchId, contexts);
461+
const client = isOpenAI ? this.openAIBatchClient : this.batchClient;
462+
if (!client) {
463+
throw new Error(`${isOpenAI ? "OpenAI" : "Anthropic"} batch client not initialized`);
464+
}
465+
const results = await client.getResults(batchId, contexts);
485466

486467
console.log(`Retrieved ${String(results.size)} results`);
487468

@@ -507,26 +488,4 @@ export class BatchModeProcessor {
507488

508489
return reassembled;
509490
}
510-
511-
/** Get results from OpenAI batch client */
512-
private async getOpenAIResults(
513-
batchId: string,
514-
contexts: Map<string, DeminifyContext>,
515-
): Promise<Map<string, DeminifyResult>> {
516-
if (!this.openAIBatchClient) {
517-
throw new Error("OpenAI batch client not initialized");
518-
}
519-
return this.openAIBatchClient.getResults(batchId, contexts);
520-
}
521-
522-
/** Get results from Anthropic batch client */
523-
private async getAnthropicResults(
524-
batchId: string,
525-
contexts: Map<string, DeminifyContext>,
526-
): Promise<Map<string, DeminifyResult>> {
527-
if (!this.batchClient) {
528-
throw new Error("Anthropic batch client not initialized");
529-
}
530-
return this.batchClient.getResults(batchId, contexts);
531-
}
532491
}

‎packages/bun-decompile/src/lib/deminify/batch-utils.ts‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
/**
2+
* Batch mode utility functions.
3+
*/
4+
5+
import type { BatchStatus } from "./batch-client.ts";
6+
import type { OpenAIBatchStatus } from "./openai-batch.ts";
7+
8+
/** Convert OpenAI batch status to common BatchStatus */
9+
export function toCommonStatus(status: OpenAIBatchStatus): BatchStatus {
10+
return {
11+
batchId: status.batchId,
12+
status: status.status === "completed" ? "ended" : "in_progress",
13+
total: status.total,
14+
succeeded: status.completed,
15+
errored: status.failed,
16+
processing: status.total - status.completed - status.failed,
17+
};
18+
}
19+
20+
/** Format batch progress for terminal display */
21+
export function formatBatchProgress(
22+
completed: number,
23+
total: number,
24+
failed: number,
25+
): string {
26+
const pct = total > 0 ? Math.round((completed / total) * 100) : 0;
27+
return `\r Progress: ${String(completed)}/${String(total)} (${String(pct)}%) | Errors: ${String(failed)} `;
28+
}

‎packages/clauderon/web/frontend/src/components/session-list-helpers.ts‎

Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
export type FilterStatus = "all" | "running" | "idle" | "completed" | "archived";
2+
3+
const FILTER_STATUS_MAP: Record<string, FilterStatus> = {
4+
all: "all",
5+
running: "running",
6+
idle: "idle",
7+
completed: "completed",
8+
archived: "archived",
9+
};
10+
11+
export function toFilterStatus(value: string): FilterStatus | undefined {
12+
return FILTER_STATUS_MAP[value];
13+
}
14+
15+
export function getConfirmDialogTitle(type: string): string {
16+
switch (type) {
17+
case "archive":
18+
return "Archive Session";
19+
case "unarchive":
20+
return "Unarchive Session";
21+
case "refresh":
22+
return "Refresh Session";
23+
default:
24+
return "Delete Session";
25+
}
26+
}
27+
28+
export function getConfirmDialogDescription(type: string, name: string): string {
29+
switch (type) {
30+
case "archive":
31+
return `Are you sure you want to archive "${name}"?`;
32+
case "unarchive":
33+
return `Are you sure you want to restore "${name}" from the archive?`;
34+
case "refresh":
35+
return `This will pull the latest image and recreate the container for "${name}". The session history will be preserved.`;
36+
default:
37+
return `Are you sure you want to delete "${name}"? This action cannot be undone.`;
38+
}
39+
}
40+
41+
export function getConfirmDialogLabel(type: string): string {
42+
switch (type) {
43+
case "archive":
44+
return "Archive";
45+
case "unarchive":
46+
return "Unarchive";
47+
case "refresh":
48+
return "Refresh";
49+
default:
50+
return "Delete";
51+
}
52+
}
53+
54+
export const TAB_TRIGGER_CLASS =
55+
"cursor-pointer transition-all duration-200 hover:bg-primary/20 data-[state=active]:bg-primary data-[state=active]:text-primary-foreground data-[state=active]:border-2 data-[state=active]:border-primary data-[state=active]:shadow-[4px_4px_0_hsl(220,85%,25%)] data-[state=active]:font-bold";

‎packages/clauderon/web/frontend/src/components/session-list.tsx‎

Lines changed: 8 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -22,68 +22,20 @@ import {
2222
CardHeader,
2323
} from "@/components/ui/card";
2424
import { Skeleton } from "@/components/ui/skeleton";
25+
import {
26+
type FilterStatus,
27+
toFilterStatus,
28+
getConfirmDialogTitle,
29+
getConfirmDialogDescription,
30+
getConfirmDialogLabel,
31+
TAB_TRIGGER_CLASS,
32+
} from "./session-list-helpers.ts";
2533

2634
type SessionListProps = {
2735
onAttach: (session: Session) => void;
2836
onCreateNew: () => void;
2937
};
3038

31-
type FilterStatus = "all" | "running" | "idle" | "completed" | "archived";
32-
33-
const FILTER_STATUS_MAP: Record<string, FilterStatus> = {
34-
all: "all",
35-
running: "running",
36-
idle: "idle",
37-
completed: "completed",
38-
archived: "archived",
39-
};
40-
41-
function toFilterStatus(value: string): FilterStatus | undefined {
42-
return FILTER_STATUS_MAP[value];
43-
}
44-
45-
function getConfirmDialogTitle(type: string): string {
46-
switch (type) {
47-
case "archive":
48-
return "Archive Session";
49-
case "unarchive":
50-
return "Unarchive Session";
51-
case "refresh":
52-
return "Refresh Session";
53-
default:
54-
return "Delete Session";
55-
}
56-
}
57-
58-
function getConfirmDialogDescription(type: string, name: string): string {
59-
switch (type) {
60-
case "archive":
61-
return `Are you sure you want to archive "${name}"?`;
62-
case "unarchive":
63-
return `Are you sure you want to restore "${name}" from the archive?`;
64-
case "refresh":
65-
return `This will pull the latest image and recreate the container for "${name}". The session history will be preserved.`;
66-
default:
67-
return `Are you sure you want to delete "${name}"? This action cannot be undone.`;
68-
}
69-
}
70-
71-
function getConfirmDialogLabel(type: string): string {
72-
switch (type) {
73-
case "archive":
74-
return "Archive";
75-
case "unarchive":
76-
return "Unarchive";
77-
case "refresh":
78-
return "Refresh";
79-
default:
80-
return "Delete";
81-
}
82-
}
83-
84-
const TAB_TRIGGER_CLASS =
85-
"cursor-pointer transition-all duration-200 hover:bg-primary/20 data-[state=active]:bg-primary data-[state=active]:text-primary-foreground data-[state=active]:border-2 data-[state=active]:border-primary data-[state=active]:shadow-[4px_4px_0_hsl(220,85%,25%)] data-[state=active]:font-bold";
86-
8739
export function SessionList({ onAttach, onCreateNew }: SessionListProps) {
8840
const {
8941
sessions,

0 commit comments

Comments
 (0)