fix(ci): helm-push downloads flat cdk8s dist (drop fatal **/* glob) (#1607)

helm-push failed deterministically on every main build (6007: "no artifacts
found for downloading"). verify uploads the cdk8s synth as FLAT files
(dist/<chart>.k8s.yaml — 32 of them). helm-push's first download was
`dist/**/*`, whose `**/*` needs a subdirectory segment, so it matched none of
the flat files; buildkite-agent treats "no artifacts found" as fatal and killed
the step before the `dist/*` download (which does match) ever ran.

Drop the fatal `dist/**/*` line; `dist/*` retrieves the flat synth output.
(The `sjer.red/dist/**/*` download elsewhere is fine — that dist has nested
`_astro/` subdirs, so it matches.)

Co-authored-by: CI Bot <ci@sjer.red>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: 3 people

.buildkite/pipeline.yml

@@ -1067,7 +1067,11 @@ steps:
     command: |
       if ! bash .buildkite/scripts/ci-changed.sh helm; then exit 0; fi
       . .buildkite/scripts/toolchain.sh
-      buildkite-agent artifact download "packages/homelab/src/cdk8s/dist/**/*" . --step verify
+      # cdk8s synth output is flat (`dist/<chart>.k8s.yaml`), so `dist/*` matches
+      # it. The former `dist/**/*` download failed fatally here: buildkite-agent's
+      # `**/*` needs a subdirectory segment, matches none of the flat files, and
+      # treats "no artifacts found" as fatal — killing the step before this
+      # `dist/*` download (which does match) ever ran (build 6007).
       buildkite-agent artifact download "packages/homelab/src/cdk8s/dist/*" . --step verify
       bun --no-install packages/homelab/scripts/helm-push.ts "$BUILDKITE_BUILD_NUMBER"
     retry: *retry