Skip to content

Commit 2d78ba5

Browse files
committed
made changes from comments
1 parent 071cc21 commit 2d78ba5

File tree

3 files changed

+9
-11
lines changed

3 files changed

+9
-11
lines changed

.github/workflows/test-workflow.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616

1717
- name: Print current build ID
1818
run: |
19-
echo Integration test run: githubactionsamazonecsdeplo-NWcjHIgDJLXw:b758d9f2-aea6-4592-906f-aae8754d98b4
19+
echo Integration test run: githubactionsamazonecsdeplo-NWcjHIgDJLXw:73193632-fdb5-4eea-b8b8-7c9afb374ce0
2020
2121
- name: Configure AWS credentials
2222
uses: aws-actions/configure-aws-credentials@v1
@@ -26,18 +26,18 @@ jobs:
2626
aws-region: us-west-2
2727

2828
- name: Deploy Amazon ECS task definition With Wait For Task Stopped Being False
29-
uses: aws-actions/amazon-ecs-deploy-task-definition@b3a528eb690c86037acd19fd6a2a86337f4e3657
29+
uses: aws-actions/amazon-ecs-deploy-task-definition@1a69daea10712415b65b5c90f8c41b1b6b556ab5
3030
with:
3131
task-definition: task-definition-run-task.json
3232
cluster: github-actions-deploy-task-def-integ-test
3333
run-task: true
3434
run-task-subnets: subnet-e5604fce, subnet-fe9355b4, subnet-c49431bc, subnet-392f9b64
35-
run-task-security-groups: sg-067ebcde49c0f3ad8
35+
run-task-security-groups: sg-067ebcde49c0f3ad8
3636
run-task-launch-type: FARGATE
37-
wait-for-task-stopped: false
37+
wait-for-task-stopped: false
3838

3939
- name: Deploy Amazon ECS task definition With Wait For Task Stopped Being True
40-
uses: aws-actions/amazon-ecs-deploy-task-definition@b3a528eb690c86037acd19fd6a2a86337f4e3657
40+
uses: aws-actions/amazon-ecs-deploy-task-definition@1a69daea10712415b65b5c90f8c41b1b6b556ab5
4141
with:
4242
task-definition: task-definition-run-task.json
4343
cluster: github-actions-deploy-task-def-integ-test
@@ -48,9 +48,9 @@ jobs:
4848
wait-for-task-stopped: true
4949

5050
- name: Deploy Amazon ECS task definition
51-
uses: aws-actions/amazon-ecs-deploy-task-definition@b3a528eb690c86037acd19fd6a2a86337f4e3657
51+
uses: aws-actions/amazon-ecs-deploy-task-definition@1a69daea10712415b65b5c90f8c41b1b6b556ab5
5252
with:
5353
task-definition: task-definition.json
54-
service: github-actions-deploy-task-def-integ-test
54+
service: github-actions-deploy-task-def-integ-test
5555
cluster: github-actions-deploy-task-def-integ-test
5656
wait-for-service-stability: true

task-definition-run-task.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
{
2-
32
"containerDefinitions": [
43
{
54
"memory": 32,
@@ -23,5 +22,4 @@
2322
],
2423
"networkMode": "awsvpc",
2524
"cpu": "256"
26-
2725
}

test-workflow.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,6 @@ jobs:
5151
uses: aws-actions/amazon-ecs-deploy-task-definition@v1
5252
with:
5353
task-definition: task-definition.json
54-
service: github-actions-deploy-task-def-integ-test
54+
service: github-actions-deploy-task-def-integ-test
5555
cluster: github-actions-deploy-task-def-integ-test
56-
wait-for-service-stability: true
56+
wait-for-service-stability: true

0 commit comments

Comments
 (0)