Skip to content

Commit 3d45493

Browse files
committed
removing env block
1 parent b5db699 commit 3d45493

File tree

2 files changed

+14
-32
lines changed

2 files changed

+14
-32
lines changed

.github/workflows/test-workflow.yml

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,6 @@ on:
33
branches:
44
- integ-tests
55

6-
env:
7-
AWS_REGION: us-west-2
8-
ECR_REPOSITORY: cdk-hnb659fds-container-assets-708414441733-us-west-2
9-
ECS_SERVICE: github-actions-deploy-task-def-integ-test
10-
ECS_CLUSTER: github-actions-deploy-task-def-integ-test
11-
ECS_TASK_DEFINITION: task-definition.json
12-
ECS_TASK_DEFINITION_RUN_TASK: task-definition-run-task.json
13-
CONTAINER_NAME: web
14-
156
name: Integration Test
167

178
jobs:
@@ -37,8 +28,8 @@ jobs:
3728
- name: Deploy Amazon ECS task definition With Wait For Task Stopped Being False
3829
uses: aws-actions/amazon-ecs-deploy-task-definition@1a69daea10712415b65b5c90f8c41b1b6b556ab5
3930
with:
40-
task-definition: ${{ env.ECS_TASK_DEFINITION_RUN_TASK }}
41-
cluster: ${{ env.ECS_CLUSTER }}
31+
task-definition: task-definition-run-task.json
32+
cluster: github-actions-deploy-task-def-integ-test
4233
run-task: true
4334
run-task-subnets: subnet-e5604fce, subnet-fe9355b4, subnet-c49431bc, subnet-392f9b64
4435
run-task-assign-public-IP: ENABLED
@@ -49,8 +40,8 @@ jobs:
4940
- name: Deploy Amazon ECS task definition With Wait For Task Stopped Being True
5041
uses: aws-actions/amazon-ecs-deploy-task-definition@1a69daea10712415b65b5c90f8c41b1b6b556ab5
5142
with:
52-
task-definition: ${{ env.ECS_TASK_DEFINITION_RUN_TASK }}
53-
cluster: ${{ env.ECS_CLUSTER }}
43+
task-definition: task-definition-run-task.json
44+
cluster: github-actions-deploy-task-def-integ-test
5445
run-task: true
5546
run-task-subnets: subnet-e5604fce, subnet-fe9355b4, subnet-c49431bc, subnet-392f9b64
5647
run-task-assign-public-IP: ENABLED
@@ -61,7 +52,7 @@ jobs:
6152
- name: Deploy Amazon ECS task definition
6253
uses: aws-actions/amazon-ecs-deploy-task-definition@1a69daea10712415b65b5c90f8c41b1b6b556ab5
6354
with:
64-
task-definition: ${{ env.ECS_TASK_DEFINITION }}
65-
service: ${{ env.ECS_SERVICE }}
66-
cluster: ${{ env.ECS_CLUSTER }}
55+
task-definition: task-definition.json
56+
service: github-actions-deploy-task-def-integ-test
57+
cluster: github-actions-deploy-task-def-integ-test
6758
wait-for-service-stability: true

test-workflow.yml

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,6 @@ on:
33
branches:
44
- integ-tests
55

6-
env:
7-
AWS_REGION: us-west-2
8-
ECR_REPOSITORY: cdk-hnb659fds-container-assets-708414441733-us-west-2
9-
ECS_SERVICE: github-actions-deploy-task-def-integ-test
10-
ECS_CLUSTER: github-actions-deploy-task-def-integ-test
11-
ECS_TASK_DEFINITION: task-definition.json
12-
ECS_TASK_DEFINITION_RUN_TASK: task-definition-run-task.json
13-
CONTAINER_NAME: web
14-
156
name: Integration Test
167

178
jobs:
@@ -37,8 +28,8 @@ jobs:
3728
- name: Deploy Amazon ECS task definition With Wait For Task Stopped Being False
3829
uses: aws-actions/amazon-ecs-deploy-task-definition@v1
3930
with:
40-
task-definition: ${{ env.ECS_TASK_DEFINITION_RUN_TASK }}
41-
cluster: ${{ env.ECS_CLUSTER }}
31+
task-definition: task-definition-run-task.json
32+
cluster: github-actions-deploy-task-def-integ-test
4233
run-task: true
4334
run-task-subnets: subnet-e5604fce, subnet-fe9355b4, subnet-c49431bc, subnet-392f9b64
4435
run-task-assign-public-IP: ENABLED
@@ -49,8 +40,8 @@ jobs:
4940
- name: Deploy Amazon ECS task definition With Wait For Task Stopped Being True
5041
uses: aws-actions/amazon-ecs-deploy-task-definition@v1
5142
with:
52-
task-definition: ${{ env.ECS_TASK_DEFINITION_RUN_TASK }}
53-
cluster: ${{ env.ECS_CLUSTER }}
43+
task-definition: task-definition-run-task.json
44+
cluster: github-actions-deploy-task-def-integ-test
5445
run-task: true
5546
run-task-subnets: subnet-e5604fce, subnet-fe9355b4, subnet-c49431bc, subnet-392f9b64
5647
run-task-assign-public-IP: ENABLED
@@ -61,7 +52,7 @@ jobs:
6152
- name: Deploy Amazon ECS task definition
6253
uses: aws-actions/amazon-ecs-deploy-task-definition@v1
6354
with:
64-
task-definition: ${{ env.ECS_TASK_DEFINITION }}
65-
service: ${{ env.ECS_SERVICE }}
66-
cluster: ${{ env.ECS_CLUSTER }}
55+
task-definition: task-definition.json
56+
service: github-actions-deploy-task-def-integ-test
57+
cluster: github-actions-deploy-task-def-integ-test
6758
wait-for-service-stability: true

0 commit comments

Comments
 (0)