[ISSUE alibaba#14016]: when import or export, chose healthy node to do (alibaba#14028)

Author: FangYuan33

console/src/main/java/com/alibaba/nacos/console/handler/impl/remote/config/ConfigImportAndExportService.java

@@ -17,19 +17,23 @@
 package com.alibaba.nacos.console.handler.impl.remote.config;
 
 import com.alibaba.nacos.api.common.Constants;
+import com.alibaba.nacos.api.common.NodeState;
 import com.alibaba.nacos.api.config.model.SameConfigPolicy;
 import com.alibaba.nacos.api.exception.NacosException;
 import com.alibaba.nacos.api.exception.runtime.NacosRuntimeException;
+import com.alibaba.nacos.api.model.response.NacosMember;
 import com.alibaba.nacos.api.model.v2.Result;
 import com.alibaba.nacos.auth.config.NacosAuthConfig;
 import com.alibaba.nacos.auth.config.NacosAuthConfigHolder;
 import com.alibaba.nacos.common.http.HttpUtils;
 import com.alibaba.nacos.common.http.param.Query;
+import com.alibaba.nacos.common.utils.CollectionUtils;
 import com.alibaba.nacos.common.utils.IoUtils;
 import com.alibaba.nacos.common.utils.JacksonUtils;
 import com.alibaba.nacos.common.utils.StringUtils;
 import com.alibaba.nacos.config.server.utils.RequestUtil;
 import com.alibaba.nacos.console.config.NacosConsoleAuthConfig;
+import com.alibaba.nacos.console.handler.core.ClusterHandler;
 import com.alibaba.nacos.console.handler.impl.remote.EnabledRemoteHandler;
 import com.alibaba.nacos.core.cluster.Member;
 import com.alibaba.nacos.core.cluster.NacosMemberManager;
@@ -64,6 +68,7 @@
 import java.util.Collection;
 import java.util.List;
 import java.util.Map;
+import java.util.stream.Collectors;
 
 /**
  * Nacos config import and export service.
@@ -81,9 +86,12 @@ public class ConfigImportAndExportService {
     private static final String REMOTE_CONFIG_EXPORT_URL = "http://%s%s/v3/admin/cs/config/export";
 
     private final NacosMemberManager memberManager;
+
+    private final ClusterHandler remoteClusterHandler;
 
-    public ConfigImportAndExportService(NacosMemberManager memberManager) {
+    public ConfigImportAndExportService(NacosMemberManager memberManager, ClusterHandler remoteClusterHandler) {
         this.memberManager = memberManager;
+        this.remoteClusterHandler = remoteClusterHandler;
     }
 
     /**
@@ -98,9 +106,9 @@ public ConfigImportAndExportService(NacosMemberManager memberManager) {
      * @return Maps of import success and failed count
      */
     public Result<Map<String, Object>> importConfig(String sourceUser, String namespaceId, SameConfigPolicy policy,
-            MultipartFile importFile, String sourceIp, String sourceApp) {
+            MultipartFile importFile, String sourceIp, String sourceApp) throws NacosException {
         String serverContextPath = getServerContextPath();
-        Member serverMember = randomOneMember();
+        Member serverMember = randomOneHealthyMember();
         String url = String.format(REMOTE_CONFIG_IMPORT_URL, serverMember.getAddress(), serverContextPath);
         try (CloseableHttpClient httpClient = HttpClients.createDefault()) {
             Query query = Query.newInstance().addParam("namespaceId", namespaceId).addParam("srcUser", sourceUser);
@@ -145,7 +153,7 @@ public Result<Map<String, Object>> importConfig(String sourceUser, String namesp
     public ResponseEntity<byte[]> exportConfig(String dataId, String group, String namespaceId, String appName,
             List<Long> ids) throws Exception {
         String serverContextPath = getServerContextPath();
-        Member serverMember = randomOneMember();
+        Member serverMember = randomOneHealthyMember();
         String url = String.format(REMOTE_CONFIG_EXPORT_URL, serverMember.getAddress(), serverContextPath);
         try (CloseableHttpClient httpClient = HttpClients.createDefault()) {
             Query query = Query.newInstance().addParam("namespaceId", namespaceId).addParam("dataId", dataId)
@@ -176,8 +184,19 @@ private String getServerContextPath() {
         return EnvUtil.getProperty("nacos.console.remote.server.context-path", "/nacos");
     }
 
-    private Member randomOneMember() {
+    private Member randomOneHealthyMember() throws NacosException {
+        // all nodes in cluster.conf
         Collection<Member> allMembers = memberManager.allMembers();
+        // nodes with state  in cluster
+        Collection<? extends NacosMember> membersWithState = remoteClusterHandler.getNodeList("");
+        Map<String, NodeState> nodeStateMap = membersWithState
+                .stream().collect(Collectors.toMap(NacosMember::getAddress, NacosMember::getState));
+        // remove unhealthy nodes
+        allMembers.removeIf(node -> !NodeState.UP.equals(nodeStateMap.get(node.getAddress())));
+        if (CollectionUtils.isEmpty(allMembers)) {
+            throw new NacosRuntimeException(NacosException.SERVER_ERROR, "No healthy server node found.");
+        }
+
         return allMembers.parallelStream().findAny().orElseThrow();
     }
 

console/src/test/java/com/alibaba/nacos/console/handler/impl/remote/config/ConfigImportAndExportServiceTest.java

@@ -16,10 +16,13 @@
 
 package com.alibaba.nacos.console.handler.impl.remote.config;
 
+import com.alibaba.nacos.api.common.NodeState;
 import com.alibaba.nacos.api.config.model.SameConfigPolicy;
+import com.alibaba.nacos.api.exception.NacosException;
 import com.alibaba.nacos.api.exception.runtime.NacosRuntimeException;
 import com.alibaba.nacos.api.model.v2.Result;
 import com.alibaba.nacos.common.utils.JacksonUtils;
+import com.alibaba.nacos.console.handler.core.ClusterHandler;
 import com.alibaba.nacos.core.cluster.Member;
 import com.alibaba.nacos.core.cluster.NacosMemberManager;
 import com.alibaba.nacos.sys.env.EnvUtil;
@@ -51,6 +54,8 @@
 import java.io.InputStream;
 import java.util.Collections;
 import java.util.Map;
+import java.util.Collection;
+import java.util.HashSet;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
@@ -63,6 +68,8 @@ class ConfigImportAndExportServiceTest {
 
     @Mock
     NacosMemberManager memberManager;
+    @Mock
+    ClusterHandler clusterHandler;
 
     @Mock
     CloseableHttpClient httpClient;
@@ -74,18 +81,23 @@ class ConfigImportAndExportServiceTest {
     private ConfigurableEnvironment cachedEnvironment;
 
     @BeforeEach
-    void setUp() {
+    void setUp() throws NacosException {
         cachedEnvironment = EnvUtil.getEnvironment();
         MockEnvironment environment = new MockEnvironment();
         environment.setProperty("nacos.core.auth.admin.enabled", "false");
         EnvUtil.setEnvironment(environment);
-        service = new ConfigImportAndExportService(memberManager);
+        service = new ConfigImportAndExportService(memberManager, clusterHandler);
         httpClientMock = Mockito.mockStatic(HttpClients.class);
         httpClientMock.when(HttpClients::createDefault).thenReturn(httpClient);
         Member member = new Member();
         member.setIp("127.0.0.1");
         member.setPort(8080);
-        when(memberManager.allMembers()).thenReturn(Collections.singleton(member));
+        member.setState(NodeState.UP);
+
+        Collection nacosMembers = new HashSet<>();
+        nacosMembers.add(member);
+        when(memberManager.allMembers()).thenReturn(nacosMembers);
+        when(clusterHandler.getNodeList(any())).thenReturn(nacosMembers);
     }
 
     @AfterEach
@@ -95,7 +107,7 @@ void tearDown() {
     }
 
     @Test
-    void importConfig() throws IOException {
+    void importConfig() throws IOException, NacosException {
         MultipartFile mockFile = Mockito.mock(MultipartFile.class);
         when(mockFile.getContentType()).thenReturn(MediaType.MULTIPART_FORM_DATA_VALUE);
         when(mockFile.getOriginalFilename()).thenReturn("file");
@@ -167,9 +179,10 @@ void exportConfigWithIoException() throws Exception {
     }
 
     @Test
-    void exportHttpClientResponseHandlerHandleResponse() throws ProtocolException, IOException {
+    void exportHttpClientResponseHandlerHandleResponse() throws ProtocolException, IOException, NacosException {
         // remove lenient warning
         memberManager.allMembers();
+        clusterHandler.getNodeList("");
         ClassicHttpResponse mockResponse = Mockito.mock(ClassicHttpResponse.class);
         when(mockResponse.getHeader("Content-Disposition")).thenReturn(
                 new BasicHeader("Content-Disposition", "testDisposition"));
@@ -186,9 +199,10 @@ void exportHttpClientResponseHandlerHandleResponse() throws ProtocolException, I
     }
 
     @Test
-    void exportHttpClientResponseHandlerHandleResponseWithException() throws ProtocolException {
+    void exportHttpClientResponseHandlerHandleResponseWithException() throws ProtocolException, NacosException {
         // remove lenient warning
         memberManager.allMembers();
+        clusterHandler.getNodeList("");
         ClassicHttpResponse mockResponse = Mockito.mock(ClassicHttpResponse.class);
         when(mockResponse.getHeader("Content-Disposition")).thenThrow(new ProtocolException());
         ConfigImportAndExportService.ExportHttpClientResponseHandler handler = new ConfigImportAndExportService.ExportHttpClientResponseHandler();