Skip to content

Commit cab1aee

Browse files
committed
more ci fixes
1 parent 3014192 commit cab1aee

6 files changed

Lines changed: 124 additions & 40 deletions

File tree

.github/workflows/ci.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ jobs:
1414
steps:
1515
- name: Checkout repository
1616
uses: actions/checkout@v4
17+
with:
18+
submodules: true
1719

1820
- name: Setup pnpm
1921
uses: pnpm/action-setup@v4
@@ -39,6 +41,8 @@ jobs:
3941
steps:
4042
- name: Checkout repository
4143
uses: actions/checkout@v4
44+
with:
45+
submodules: true
4246

4347
- name: Setup pnpm
4448
uses: pnpm/action-setup@v4
@@ -64,6 +68,8 @@ jobs:
6468
steps:
6569
- name: Checkout repository
6670
uses: actions/checkout@v4
71+
with:
72+
submodules: true
6773

6874
- name: Setup pnpm
6975
uses: pnpm/action-setup@v4
@@ -80,6 +86,9 @@ jobs:
8086
- name: Install dependencies
8187
run: pnpm install --frozen-lockfile
8288

89+
- name: Build native module
90+
run: pnpm build:native
91+
8392
- name: Run integration tests
8493
run: pnpm test:integration
8594

@@ -90,6 +99,8 @@ jobs:
9099
steps:
91100
- name: Checkout repository
92101
uses: actions/checkout@v4
102+
with:
103+
submodules: true
93104

94105
- name: Setup pnpm
95106
uses: pnpm/action-setup@v4

.github/workflows/deadcode.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ jobs:
1212
steps:
1313
- name: Checkout repository
1414
uses: actions/checkout@v4
15+
with:
16+
submodules: true
1517

1618
- name: Setup pnpm
1719
uses: pnpm/action-setup@v4

apps/desktop/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
"@electron/fuses": "^1.8.0",
3535
"@tailwindcss/vite": "^4.1.11",
3636
"@types/electron-squirrel-startup": "^1.0.2",
37+
"@types/node": "^25.3.0",
3738
"@types/throttle-debounce": "^5.0.2",
3839
"@vitejs/plugin-react": "^4.6.0",
3940
"electron": "40.1.0",

apps/desktop/src/renderer/src/engine/editing.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,7 @@ export class EditingManager {
173173
this.#dispatchVoid(this.#engine.raw.removePoints(pointIds));
174174
}
175175

176+
/** @knipclassignore used via Pick<EditingManager, CommandEditingMethods> */
176177
insertPointBefore(beforePointId: PointId, edit: PointEdit): PointId {
177178
const ids = this.#dispatch(
178179
this.#engine.raw.insertPointBefore(
@@ -214,6 +215,7 @@ export class EditingManager {
214215
this.#dispatchVoid(this.#engine.raw.setXAdvance(width));
215216
}
216217

218+
/** @knipclassignore used via Pick<EditingManager, CommandEditingMethods> */
217219
translateLayer(dx: number, dy: number): void {
218220
this.#dispatchVoid(this.#engine.raw.translateLayer(dx, dy));
219221
}
@@ -231,10 +233,12 @@ export class EditingManager {
231233
this.#dispatchVoid(this.#engine.raw.reverseContour(contourId));
232234
}
233235

236+
/** @knipclassignore used via Pick<EditingManager, CommandEditingMethods> */
234237
removeContour(contourId: ContourId): void {
235238
this.#dispatchVoid(this.#engine.raw.removeContour(contourId));
236239
}
237240

241+
/** @knipclassignore used via Pick<EditingManager, CommandEditingMethods> */
238242
openContour(contourId: ContourId): void {
239243
this.#dispatchVoid(this.#engine.raw.openContour(contourId));
240244
}

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
"private": true,
55
"description": "Shift font editor monorepo",
66
"scripts": {
7+
"prepare": "git submodule update --init --recursive && pnpm generate:glyph-info",
78
"dev": "pnpm run build:native:debug && pnpm --filter @shift/desktop dev",
89
"dev:watch": "scripts/watch.sh",
910
"build": "turbo run build",

0 commit comments

Comments
 (0)