[WIP] SwiftUI view の実装を追加 #212
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zztkm
force-pushed
the
feature/swiftui-view
branch
from
eee7400 to
f1776d9
Compare
zztkm
commented
Jan 31, 2025
Comment on lines
+185
to
+197
| class VideoController: ObservableObject { | ||
| var stream: MediaStream? | ||
|
|
||
| // init() で VideoView を生成すると次のエラーが出るので、生成のタイミングを遅らせておく | ||
| // Failed to bind EAGLDrawable: <CAEAGLLayer: 0x********> to GL_RENDERBUFFER 1 | ||
| lazy var videoView = VideoView() | ||
|
|
||
| @Published var isCleared: Bool = false | ||
|
|
||
| init(stream: MediaStream?) { | ||
| self.stream = stream | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
SwiftUIVideoView の内部状態を変えたいユーザーのための VideoController.
こいつはユーザーの View 内で利用することを想定してるので、状態変更用のメソッドを実装して提供してあげる必要がある(というのを以前実装したときは理解できてなかった。
状態変更のロジックは VideoController に寄せると View の実装がシンプルになって良さそう。
Contributor
Author
|
別のブランチで対応を進めるためクローズします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
以前の PR の再実装: #140