Rid 列挙型を追加する #295
Merged
Rid 列挙型を追加する #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
zztkm
commented
Jan 6, 2026
Comment on lines
+52
to
+66
| - RPC メソッドを表す列挙型 `RPCMethod` を追加する | ||
| - `SignalingOffer` に以下の項目を追加する | ||
| - `rpcMethods: [String]?` | ||
| - `simulcastRpcRids: [Rid]?` を追加する | ||
| - `MediaChannel` に `rpc` メソッドを追加する | ||
| - `MediaChannel` に以下の項目を追加する | ||
| - `rpcMethods: [RPCMethod]` | ||
| - `rpcSimulcastRids: [Rid]` | ||
| - RPC メソッドを定義するための `RPCMethodProtocol` プロトコルを追加する | ||
| - `RPCMethodProtocol` に準拠した型を追加する | ||
| - `RequestSimulcastRid` | ||
| - `RequestSpotlightRid` | ||
| - `ResetSpotlightRid` | ||
| - `PutSignalingNotifyMetadata` | ||
| - `PutSignalingNotifyMetadataItem` |
zztkm
commented
Jan 6, 2026
Comment on lines
+10
to
+21
| # build | ||
| build: | ||
| xcodebuild \ | ||
| -scheme 'Sora' \ | ||
| -sdk iphoneos26.1 \ | ||
| -configuration Release \ | ||
| -derivedDataPath build \ | ||
| -destination 'generic/platform=iOS' \ | ||
| clean build \ | ||
| CODE_SIGNING_REQUIRED=NO \ | ||
| CODE_SIGN_IDENTITY= \ | ||
| PROVISIONING_PROFILE= |
Contributor
Author
|
!sonnet commit 109547f で Rid 型変更が漏れていた箇所を追加対応しました。問題ないかレビューして |
|
Claude finished @zztkm's task in 1m 25s —— View job レビュー完了コミット 109547f の変更内容を確認しました。問題ありません。 確認事項
型変更が漏れていた箇所 (コミット 109547f で対応済み)コミット 109547f で以下の箇所が適切に修正されています:
CHANGES.md について66-80 行目の追加内容について、RPC 機能追加の記載は適切です。ただし、67 行目の「Rid 列挙型を追加する」という項目が追加されていますが、これは既に PR #295 のメインテーマとして最初のコミットで実装済みの内容です。この項目は重複している可能性があります。 総評問題なし。 コミット 109547f で RPCTypes.swift の型変更が完全に対応されています。Rid 型への変換は一貫しており、変換漏れはありません。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimulcastRequestRid は unspecified (未指定) が含まれており、Signaling の type: connect 用になっている。
そのため、この型を RPC 機能などの rid を表す項目に利用するのは不適切であると判断し、Rid 列挙型を新たに追加してこの型を利用するように変更した。