-
Notifications
You must be signed in to change notification settings - Fork 10
setVideoSoftMute / setVideoHardMute を追加 #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
!haiku レビューして |
This comment was marked as resolved.
This comment was marked as resolved.
|
!haiku 指摘に対して修正した内容のレビューして |
This comment was marked as resolved.
This comment was marked as resolved.
|
!haiku |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This comment was marked as resolved.
This comment was marked as resolved.
|
!sonnet haiku のレビューも踏まえてダブルチェックして |
This comment was marked as resolved.
This comment was marked as resolved.
zztkm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
Sora/MediaStream.swift
Outdated
|
|
||
| /// 映像トラックを保持している場合は ``true`` を返します。 | ||
| /// | ||
| /// SDK 内部で利用する判定用のプロパティです。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これいる?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MediaChannel から直接取れるのか確認します
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MediaChannel.setVideoSoft(Hard)Mute 実行時にローカルトラックが存在しない場合にエラーで返せないため必要です
- MediaStream がローカルトラックを公開していない
- MediaStream.videoEnabled setter が返り値を返さない(ローカルトラックがなければ何もしない)ため
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
というのをコメントに書くととても良いです。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あ、ごめんこれ閉じちゃった。コメントに残しておいて。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なるほど承知です
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hasAudioTrack も同様なので併せてコメント追加しました
|
!haiku 追加したコメント等のレビューして |
This comment was marked as resolved.
This comment was marked as resolved.
|
!haiku 修正した内容で再度レビューして |
This comment was marked as resolved.
This comment was marked as resolved.
|
!haiku 再度レビューして |
This comment was marked as resolved.
This comment was marked as resolved.
|
!haiku VideoMute.swift VideoHardMuteSerialQueue を VideoHardMuteActor に変更したのでレビューして |
This comment was marked as resolved.
This comment was marked as resolved.
|
指摘事項(不足コメントの追加)を対応しました。 |
| XCODE: /Applications/Xcode_16.3.app | ||
| XCODE_SDK: iphoneos18.4 | ||
| XCODE: /Applications/Xcode_16.4.app | ||
| XCODE_SDK: iphoneos18.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI が 18.4 では通らなくなってしまったため上げています
60ca039 to
e673bc2
Compare
Sora/MediaStream.swift
Outdated
|
|
||
| /// 映像トラックを保持している場合は ``true`` を返します。 | ||
| /// | ||
| /// SDK 内部で利用する判定用のプロパティです。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あ、ごめんこれ閉じちゃった。コメントに残しておいて。
No description provided.