Skip to content

Conversation

@t-miya
Copy link
Contributor

@t-miya t-miya commented Jan 8, 2026

No description provided.

@t-miya
Copy link
Contributor Author

t-miya commented Jan 8, 2026

!haiku レビューして

@github-actions

This comment was marked as resolved.

@t-miya
Copy link
Contributor Author

t-miya commented Jan 8, 2026

!haiku 指摘に対して修正した内容のレビューして

@github-actions

This comment was marked as resolved.

@t-miya
Copy link
Contributor Author

t-miya commented Jan 8, 2026

!haiku ドキュメント表現の詳細レベルの差 の対応を行った

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Claude encountered an error —— View job


I'll analyze this and get back to you.

@github-actions

This comment was marked as resolved.

@t-miya
Copy link
Contributor Author

t-miya commented Jan 8, 2026

!sonnet haiku のレビューも踏まえてダブルチェックして

@github-actions

This comment was marked as resolved.

@t-miya t-miya changed the title (WIP)setVideoSoftMute / setVideoHardMute を追加 setVideoSoftMute / setVideoHardMute を追加 Jan 8, 2026
Copy link
Contributor

@zztkm zztkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼


/// 映像トラックを保持している場合は ``true`` を返します。
///
/// SDK 内部で利用する判定用のプロパティです。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これいる?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MediaChannel から直接取れるのか確認します

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MediaChannel.setVideoSoft(Hard)Mute 実行時にローカルトラックが存在しない場合にエラーで返せないため必要です

  • MediaStream がローカルトラックを公開していない
  • MediaStream.videoEnabled setter が返り値を返さない(ローカルトラックがなければ何もしない)ため

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

というのをコメントに書くととても良いです。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、ごめんこれ閉じちゃった。コメントに残しておいて。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほど承知です

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hasAudioTrack も同様なので併せてコメント追加しました

@t-miya
Copy link
Contributor Author

t-miya commented Jan 9, 2026

!haiku 追加したコメント等のレビューして

@github-actions

This comment was marked as resolved.

@t-miya
Copy link
Contributor Author

t-miya commented Jan 9, 2026

!haiku 修正した内容で再度レビューして

@github-actions

This comment was marked as resolved.

@t-miya
Copy link
Contributor Author

t-miya commented Jan 9, 2026

!haiku 再度レビューして

@github-actions

This comment was marked as resolved.

@t-miya
Copy link
Contributor Author

t-miya commented Jan 9, 2026

!haiku VideoMute.swift VideoHardMuteSerialQueue を VideoHardMuteActor に変更したのでレビューして

@github-actions

This comment was marked as resolved.

@t-miya
Copy link
Contributor Author

t-miya commented Jan 9, 2026

指摘事項(不足コメントの追加)を対応しました。
VideoMute.rst は Actor 利用に変更して、処理の整理や説明コメントを追加しています

XCODE: /Applications/Xcode_16.3.app
XCODE_SDK: iphoneos18.4
XCODE: /Applications/Xcode_16.4.app
XCODE_SDK: iphoneos18.5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI が 18.4 では通らなくなってしまったため上げています

@t-miya t-miya force-pushed the feature/video-mute branch from 60ca039 to e673bc2 Compare January 14, 2026 02:58

/// 映像トラックを保持している場合は ``true`` を返します。
///
/// SDK 内部で利用する判定用のプロパティです。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、ごめんこれ閉じちゃった。コメントに残しておいて。

@t-miya t-miya merged commit bf80a9c into develop Jan 14, 2026
4 checks passed
@t-miya t-miya deleted the feature/video-mute branch January 14, 2026 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants