-
Notifications
You must be signed in to change notification settings - Fork 10
Configure.initialCameraEnabled を追加、接続時のカメラ初期化を遅延できるようにする #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
!haiku レビューして |
This comment was marked as resolved.
This comment was marked as resolved.
|
!haiku 修正したので再度レビューして |
This comment was marked as resolved.
This comment was marked as resolved.
|
!sonnet haiku のレビュー内容も踏まえてダブルチェックして |
This comment was marked as resolved.
This comment was marked as resolved.
zztkm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
コード中のコメントなどはわかりやすいと思いました 👍🏼
|
!haiku 修正箇所についてレビューして |
This comment was marked as resolved.
This comment was marked as resolved.
|
!haiku |
This comment was marked as resolved.
This comment was marked as resolved.
|
!haiku
|
This comment was marked as resolved.
This comment was marked as resolved.
|
!haiku VideoHardMuteActor の self.capturer は restart 用に保持している、という意図がわかりやすくなるように変数名等を修正した |
This comment was marked as resolved.
This comment was marked as resolved.
zztkm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM です !
背景
現状の実装ではカメラ有効の設定での開始時は必ずカメラキャプチャが生成されるため、カメラキャプチャの生成遅延により
開始時カメラミュートを行うことができない。
ちなみにカメラ無効で開始した場合は
MediaChannel.setVideHardMuteによる解除をすることができない。修正内容
接続設定に
initialCameraEnabledを追加することにより、カメラキャプチャの生成を遅延できるようにする。また、
VideoHardMuteActor. setMute(false)でカメラキャプチャが未生成の場合は生成するようにする。