🐛 raise CLI service errors directly

Author: shinaji

src/schnee/controllers/cli/errors.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, NoReturn
 
 import typer
 
@@ -10,7 +10,7 @@
 SERVICE_ERROR_EXIT_CODE = 1
 
 
-def exit_for_service_error(exc: ServiceError) -> typer.Exit:
-    """Render a service-level error and return a CLI exit exception."""
+def exit_for_service_error(exc: ServiceError) -> NoReturn:
+    """Render a service-level error and exit the CLI."""
     typer.echo(exc.msg, err=True)
-    return typer.Exit(code=SERVICE_ERROR_EXIT_CODE)
+    raise typer.Exit(code=SERVICE_ERROR_EXIT_CODE)

tests/schnee/controllers/cli/test_errors.py

@@ -0,0 +1,33 @@
+"""Tests for CLI error handling."""
+
+import pytest
+import typer
+
+from schnee.controllers.cli.errors import (
+    SERVICE_ERROR_EXIT_CODE,
+    exit_for_service_error,
+)
+from schnee.services.base import ServiceError
+
+
+class ExampleServiceError(ServiceError):
+    """Service error used by CLI tests."""
+
+    msg = "example service failure"
+
+
+def test_exit_for_service_error_writes_error_and_exits(
+    capsys: pytest.CaptureFixture[str],
+) -> None:
+    """Service errors are rendered to stderr and terminate the CLI."""
+    with pytest.raises(typer.Exit) as exc_info:
+        exit_for_service_error(ExampleServiceError())
+
+    captured = capsys.readouterr()
+
+    assert exc_info.value.exit_code == SERVICE_ERROR_EXIT_CODE, (
+        "service errors should terminate with the configured CLI error code"
+    )
+    assert ExampleServiceError.msg in captured.err, (
+        "service errors should be rendered to stderr before exiting"
+    )