Skip to content

Commit 7fd5322

Browse files
committed
🔒 use constant-time MAC comparison
1 parent 2437fc3 commit 7fd5322

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

‎src/schnee/services/ntag_profile.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
from __future__ import annotations
44

5+
import hmac
56
import sys
67
from typing import ClassVar, NamedTuple, Self
78

@@ -697,7 +698,7 @@ def process(self) -> VerifyNtag424SdmMacResult:
697698
counter=self.req.counter,
698699
)
699700
return VerifyNtag424SdmMacResult(
700-
valid=calculated_mac == self.req.mac,
701+
valid=hmac.compare_digest(calculated_mac, self.req.mac),
701702
calculated_mac=calculated_mac,
702703
ndef_prefix=self.req.ndef_prefix,
703704
prefix_removed=normalized_text.prefix_removed,

0 commit comments

Comments
 (0)