🐛 reject unsupported PC/SC profile reads

Author: shinaji

src/schnee/adapters/backend/pcsc/backend.py

@@ -20,6 +20,9 @@ class PcscBackendError(Exception):
     class UnsupportedPlanError(PcscBackendError):
         """Raised when a write plan is not implemented by the PC/SC backend."""
 
+    class UnsupportedProfileReadError(PcscBackendError):
+        """Raised when full profile reads are not implemented."""
+
     def __init__(self, reader: PcscReader) -> None:
         self.reader = reader
         self.client = PcscApduClient(reader)
@@ -38,13 +41,16 @@ def send_apdu(self, apdu: CommandAPDU | list[int]) -> ResponseAPDU:
         return self.client.send_apdu(apdu)
 
     def read_profile(self) -> TagProfile:
-        """Read the currently reachable NTAG profile summary."""
+        """Read the currently reachable NTAG profile."""
+        msg = "PC/SC full profile reads are not implemented yet"
+        raise self.UnsupportedProfileReadError(msg)
+
+    def read_tag_info(self) -> TagInfo:
+        """Read the currently reachable NTAG tag identity summary."""
         uid = self._read_uid()
-        return TagProfile(
-            tag=TagInfo(
-                uid=uid,
-                features=["pcsc"],
-            ),
+        return TagInfo(
+            uid=uid,
+            features=["pcsc"],
         )
 
     def apply_plan(self, plan: ChangePlan) -> TagProfile:

tests/schnee/adapters/backend/pcsc/test_backend.py

@@ -2,15 +2,12 @@
 
 from __future__ import annotations
 
-from typing import TYPE_CHECKING
+import pytest
 
 from schnee.adapters.backend import PcscBackend
 from schnee.adapters.backend.pcsc import PcscReaderProvider
 from schnee.adapters.ntag.apdu import CommandAPDU
 
-if TYPE_CHECKING:
-    import pytest
-
 
 class FakeConnection:
     """Fake PC/SC connection."""
@@ -44,19 +41,27 @@ def create_connection(self) -> FakeConnection:
         return self.connection
 
 
-def test_pcsc_backend_wraps_reader_and_reads_profile_uid() -> None:
-    """PC/SC backend reads a profile through the wrapped reader."""
+def test_pcsc_backend_reads_tag_info_uid() -> None:
+    """PC/SC backend reads tag identity through the wrapped reader."""
     reader = FakeReader()
     backend = PcscBackend(reader=reader)
 
-    profile = backend.read_profile()
+    tag = backend.read_tag_info()
 
     assert backend.reader_name == "Fake PCSC Reader"
-    assert profile.tag.uid == "04112233445566"
-    assert profile.tag.features == ["pcsc"]
+    assert tag.uid == "04112233445566"
+    assert tag.features == ["pcsc"]
     assert reader.connection.commands == [[0xFF, 0xCA, 0x00, 0x00, 0x00]]
 
 
+def test_pcsc_backend_rejects_full_profile_reads() -> None:
+    """PC/SC backend does not fabricate full profile data from UID-only reads."""
+    backend = PcscBackend(reader=FakeReader())
+
+    with pytest.raises(PcscBackend.UnsupportedProfileReadError):
+        backend.read_profile()
+
+
 def test_pcsc_backend_sends_command_apdu() -> None:
     """PC/SC backend accepts CommandAPDU objects."""
     reader = FakeReader()