Skip to content

Commit 36fd51b

Browse files
committed
fix #623 - ensure all permissions are checked
1 parent fb4d826 commit 36fd51b

File tree

3 files changed

+1
-3
lines changed

3 files changed

+1
-3
lines changed

samples/Samples/Geofences/CreatePage.xaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
<ContentPage xmlns="http://xamarin.com/schemas/2014/forms"
33
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
44
x:Class="Samples.Geofences.CreatePage"
5-
Style="{StaticResource ContentPage}"
65
Title="Create">
76

87
<ContentPage.ToolbarItems>

src/Shiny.Core/Platforms/Android/AndroidPlatform.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ public IObservable<PermissionRequestResult> RequestPermissions(params string[] a
232232
var comp = new CompositeDisposable();
233233

234234
//https://developer.android.com/training/permissions/requesting
235-
var allGood = androidPermissions.Any(p => ContextCompat.CheckSelfPermission(this.AppContext, p) == Permission.Granted);
235+
var allGood = androidPermissions.All(p => ContextCompat.CheckSelfPermission(this.AppContext, p) == Permission.Granted);
236236
if (allGood)
237237
{
238238
// everything is already good

src/Shiny.Locations/Platforms/Android/GeofenceManagerImpl.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ await this.services.RunDelegates<IGeofenceDelegate>(
6868
var regions = await this.Repository.GetAll();
6969
foreach (var region in regions)
7070
await this.Create(region);
71-
7271
}
7372

7473

0 commit comments

Comments
 (0)