chore: use for...of instead of forEach

Author: Uzlopak

packages/dtls/src/cipher/suites/aead.ts

@@ -72,14 +72,9 @@ export default class AEADCipher extends Cipher {
 
     const additionalBuffer = this.encodeAdditionalBuffer(header, data.length);
 
-    const cipher = createCipheriv(
-      this.blockAlgorithm!,
-      writeKey,
-      iv,
-      {
-        authTagLength: this.authTagLength,
-      },
-    );
+    const cipher = createCipheriv(this.blockAlgorithm!, writeKey, iv, {
+      authTagLength: this.authTagLength,
+    });
 
     cipher.setAAD(additionalBuffer, {
       plaintextLength: data.length,
@@ -128,14 +123,9 @@ export default class AEADCipher extends Cipher {
       encrypted.length,
     );
 
-    const decipher = createDecipheriv(
-      this.blockAlgorithm!,
-      writeKey,
-      iv,
-      {
-        authTagLength: this.authTagLength,
-      },
-    );
+    const decipher = createDecipheriv(this.blockAlgorithm!, writeKey, iv, {
+      authTagLength: this.authTagLength,
+    });
 
     decipher.setAuthTag(authTag);
     decipher.setAAD(additionalBuffer, {

packages/dtls/src/cipher/suites/null.ts

@@ -12,7 +12,7 @@ export default class NullCipher extends Cipher {
     super();
 
     this.name = "NULL_NULL_NULL"; // key, mac, hash
-    this.blockAlgorithm = "NULL";
+    this.blockAlgorithm = "NULL" as any;
     this.kx = createNULLKeyExchange();
     this.hashAlgorithm = "NULL";
   }

packages/dtls/src/context/cipher.ts

@@ -1,4 +1,4 @@
-import { webcrypto, createSign, randomBytes } from "crypto";
+import { createSign, randomBytes, webcrypto } from "crypto";
 import { Certificate, PrivateKey } from "@fidm/x509";
 import * as x509 from "@peculiar/x509";
 import { encode, types } from "@shinyoshiaki/binary-data";

packages/dtls/src/flight/client/flight5.ts

@@ -231,7 +231,7 @@ handlers[HandshakeType.server_hello_2] =
     log(dtls.sessionId, "selected cipherSuite", cipher.cipherSuite);
 
     if (message.extensions) {
-      message.extensions.forEach((extension) => {
+      for (const extension of message.extensions) {
         switch (extension.type) {
           case UseSRTP.type:
             {
@@ -252,7 +252,7 @@ handlers[HandshakeType.server_hello_2] =
             log(dtls.sessionId, "RenegotiationIndication");
             break;
         }
-      });
+      }
     }
   };
 

packages/dtls/src/flight/server/flight2.ts

@@ -50,7 +50,7 @@ export const flight2 =
     dtls.recordSequenceNumber = 0;
     dtls.sequenceNumber = 0;
 
-    clientHello.extensions.forEach((extension) => {
+    for (const extension of clientHello.extensions) {
       switch (extension.type) {
         case EllipticCurves.type:
           {
@@ -118,7 +118,7 @@ export const flight2 =
           }
           break;
       }
-    });
+    }
 
     cipher.localRandom = new DtlsRandom();
     cipher.remoteRandom = DtlsRandom.from(clientHello.random);

packages/dtls/tests/server.test.ts

@@ -28,7 +28,9 @@ describe("server", () => {
     const fragments = hello.toFragment().chunk(10);
     const last = fragments.pop()!;
     const second = fragments.pop()!;
-    fragments.forEach((fragment) => server.handleFragmentHandshake([fragment]));
+    for (const fragment of fragments) {
+      server.handleFragmentHandshake([fragment]);
+    }
     expect(server.handleFragmentHandshake([last]).length).toBeGreaterThan(0);
     expect(server.handleFragmentHandshake([second]).length).toBe(0);
   });