Does not respect association ON clause (acts_as_paranoid)

[mrbrdo]

Let's say the Translation model includes acts_as_paranoid.
Typical Rails Base.all.joins(:translations) will correctly have INNER JOIN ... ON ... ."deleted_at" IS NULL
However, the scopes/queries generated by Mobility will not include this ON condition.

I'm not sure how to go about fixing this... It seems the ActiveRecord interface to joins is mostly private and I didn't find a way to get a complete join (e.g. Arel join with all conditions) from ActiveRecord. I didn't find a way in ActiveRecord to perform a join with a table alias (for an association with taking into account the ON conditions).
Any suggestion? Is there at least a single place / setting in Mobility where it would be possible to add the additional conditions for the joins Mobility generates internally?

[shioyama]

Can you create either a test or a demo app which shows the issue? Also, I've tagged this with table_backend since you're referring specifically to something that impacts that backend only.

[mrbrdo]

Yes I think it only affects table_backend.

See failing spec: https://github.com/mrbrdo/mobility/blob/mrbrdo/spec/mobility/plugins/active_record/query_spec.rb#L114

[mrbrdo]

@shioyama can you comment on this failing spec?

[shioyama]

Thanks for raising the issue.

Let's say the Translation model includes acts_as_paranoid.

The Translation model is really an implementation detail, it's not built to handle things like this. I don't know how to fix this, it may be possible but it doesn't look easy.

The Table backend uses aliases to distinguish between joins in different locales, so instead of article_translations it's aliasing that to article_translations_en (say for English). That allows to do very powerful things in multiple locales without conflicts between locales, but of course in this case it makes things difficult. Even if we add the default scope into the query, which is possible, it doesn't work because it would be WHERE "article_translations"."title" != 'DELETED'" which doesn't match the join, so it fails.

If there was a simple way to add a default_scoped somewhere in either the AR table backend or in the query plugin, I'd be interested in this, but otherwise I think it's really stretching what Mobility is able to do.

Sorry about that! I suspect at least there's a fix that would work in a non-generic way, but I don't see it right now.

[shioyama]

I'd like to close this since I don't see it as an issue with Mobility, but I'll leave it open in case we can come to some generic solution.

[mrbrdo]

Possibly the last question from my OP? Is there at least a single place / setting in Mobility where it would be possible to add the additional conditions for the joins Mobility generates internally?
It would at least allow to manually update the join scope, even if it's not automatic, it would be helpful.

You can see how I patched it for now in my use case (AR backend): https://github.com/mrbrdo/spree_mobility/blob/main/lib/spree_mobility/core_ext/mobility/backends/active_record/table/mobility_acts_as_paranoid_decorator.rb

[shioyama]

Is there at least a single place / setting in Mobility where it would be possible to add the additional conditions for the joins Mobility generates internally?

It could be an option for the table backend, used in apply_scope.

Actually, it's already possible if you subclass Mobility::Backends::ActiveRecord::Table and patch the private method join_translations. So I'd suggest maybe trying that first. You can pass the new backend class to backend: rather than :table and it should work.

[mrbrdo]

That's exactly what I did: https://github.com/mrbrdo/spree_mobility/blob/main/lib/spree_mobility/core_ext/mobility/backends/active_record/table/mobility_acts_as_paranoid_decorator.rb

But was hoping for a cleaner way :)