Sort tips in transitively dead groups (#146)

Author: janedbal

src/Rule/DeadCodeRule.php

@@ -587,12 +587,13 @@ private function buildError(array $blackMembersGroup): IdentifierRuleError
             'transitive' => false,
         ];
 
+        $tips = [];
+
         foreach (array_slice($blackMembersGroup, 1) as $transitivelyDeadMember) {
             $transitiveDeadMemberRef = $transitivelyDeadMember->getMember()->toHumanString();
             $exclusionMessage = $transitivelyDeadMember->getExclusionMessage();
 
-            $builder->addTip("Thus $transitiveDeadMemberRef is transitively also unused{$exclusionMessage}");
-
+            $tips[$transitiveDeadMemberRef] = "Thus $transitiveDeadMemberRef is transitively also unused{$exclusionMessage}";
             $metadata[$transitiveDeadMemberRef] = [
                 'file' => $transitivelyDeadMember->getFile(),
                 'line' => $transitivelyDeadMember->getLine(),
@@ -602,6 +603,12 @@ private function buildError(array $blackMembersGroup): IdentifierRuleError
 
         $builder->metadata($metadata);
 
+        ksort($tips);
+
+        foreach ($tips as $tip) {
+            $builder->addTip($tip);
+        }
+
         return $builder->build();
     }
 

tests/Rule/DeadCodeRuleTest.php

@@ -242,16 +242,16 @@ public static function provideGroupingFiles(): iterable
                 [
                     'Unused Grouping\Example::boo',
                     29,
+                    "• Thus Grouping\Example::TRANSITIVELY_UNUSED_CONST is transitively also unused\n" .
                     "• Thus Grouping\Example::bag is transitively also unused\n" .
-                    "• Thus Grouping\Example::bar is transitively also unused\n" .
-                    '• Thus Grouping\Example::TRANSITIVELY_UNUSED_CONST is transitively also unused',
+                    '• Thus Grouping\Example::bar is transitively also unused',
                 ],
                 [
                     'Unused Grouping\Example::foo',
                     23,
-                    "• Thus Grouping\Example::bar is transitively also unused\n" .
+                    "• Thus Grouping\Example::TRANSITIVELY_UNUSED_CONST is transitively also unused\n" .
                     "• Thus Grouping\Example::bag is transitively also unused\n" .
-                    '• Thus Grouping\Example::TRANSITIVELY_UNUSED_CONST is transitively also unused',
+                    '• Thus Grouping\Example::bar is transitively also unused',
                 ],
                 [
                     'Unused Grouping\Example::recur',