Note ReflectionClass variance

janedbal · janedbal · commit f5c036110a30 · 2025-04-02T15:04:14.000+02:00
diff --git a/src/Provider/ReflectionUsageProvider.php b/src/Provider/ReflectionUsageProvider.php
@@ -65,6 +65,8 @@ private function processMethodCall(MethodCall $node, Scope $scope): array
                     continue;
                 }
 
+                // ideally, we should check if T is covariant (marks children as used) or invariant (should not mark children as used)
+                // the default changed in PHP 8.4, see: https://github.com/phpstan/phpstan/issues/12459#issuecomment-2607123277
                 foreach ($reflection->getActiveTemplateTypeMap()->getTypes() as $genericType) {
                     foreach ($genericType->getObjectClassReflections() as $genericReflection) {
                         $usedConstants = [

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,8 @@ private function processMethodCall(MethodCall $node, Scope $scope): array`
`65`	`65`	`continue;`
`66`	`66`	`}`
`67`	`67`
	`68`	`+ // ideally, we should check if T is covariant (marks children as used) or invariant (should not mark children as used)`
	`69`	`+ // the default changed in PHP 8.4, see: https://github.com/phpstan/phpstan/issues/12459#issuecomment-2607123277`
`68`	`70`	`foreach ($reflection->getActiveTemplateTypeMap()->getTypes() as $genericType) {`
`69`	`71`	`foreach ($genericType->getObjectClassReflections() as $genericReflection) {`
`70`	`72`	`$usedConstants = [`