Skip to content

Commit bef42b6

Browse files
author
Nick Hwang
committed
Final fixes
1 parent abc16a9 commit bef42b6

File tree

4 files changed

+31
-8
lines changed

4 files changed

+31
-8
lines changed

README.md

+24-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,29 @@ It aims to be the canonical implementation of this type of positioning, such tha
66

77
Take a look at the documentation for a more detailed explanation of why you should star it now to remember it for your next project.
88

9+
## Install
10+
11+
__npm__
12+
```sh
13+
$ npm install tether
14+
```
15+
16+
__bower__
17+
```sh
18+
$ bower install tether
19+
```
20+
21+
## Usage
22+
923
[![Tether Docs](http://i.imgur.com/YCx8cLr.png)](http://github.hubspot.com/tether/#usage)
1024

11-
### [Demo & Documentation](http://github.hubspot.com/tether/)
25+
[Demo & API Documentation](http://github.hubspot.com/tether/)
26+
27+
28+
## Contributing
29+
30+
We encourage contributions of all kinds. If you would like to contribute in some way, please review our [guidelines for contributing](CONTRIBUTING.md).
31+
32+
33+
## License
34+
Copyright © 2015 HubSpot - [MIT License](LICENSE)

dist/js/tether.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -911,9 +911,10 @@ var TetherClass = (function () {
911911
var height = elementPos.height;
912912

913913
if (width === 0 && height === 0 && typeof this.lastSize !== 'undefined') {
914+
var _lastSize = this.lastSize;
915+
914916
// We cache the height and width to make it possible to position elements that are
915917
// getting hidden.
916-
var _lastSize = this.lastSize;
917918
width = _lastSize.width;
918919
height = _lastSize.height;
919920
} else {
@@ -1270,9 +1271,10 @@ TetherBase.modules.push({
12701271
var width = _cache.width;
12711272

12721273
if (width === 0 && height === 0 && typeof this.lastSize !== 'undefined') {
1274+
var _lastSize = this.lastSize;
1275+
12731276
// Handle the item getting hidden as a result of our positioning without glitching
12741277
// the classes in and out
1275-
var _lastSize = this.lastSize;
12761278
width = _lastSize.width;
12771279
height = _lastSize.height;
12781280
}

gulpfile.js

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ var del = require('del');
22
var gulp = require('gulp');
33
var babel = require('gulp-babel');
44
var bump = require('gulp-bump');
5-
var coffee = require('gulp-coffee');
65
var concat = require('gulp-concat');
76
var filter = require('gulp-filter');
87
var header = require('gulp-header');

package.json

+3-4
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,14 @@
1616
"main": "dist/js/tether.js",
1717
"devDependencies": {
1818
"del": "^1.1.1",
19-
"gulp": "^3.8.11",
20-
"gulp-autoprefixer": "^2.3.0",
19+
"gulp": "^3.9.0",
20+
"gulp-autoprefixer": "^2.3.1",
2121
"gulp-babel": "^5.1.0",
2222
"gulp-bump": "^0.3.0",
23-
"gulp-coffee": "^2.3.1",
2423
"gulp-concat": "^2.5.2",
2524
"gulp-filter": "^2.0.2",
2625
"gulp-header": "^1.2.2",
27-
"gulp-minify-css": "^1.1.5",
26+
"gulp-minify-css": "^1.1.6",
2827
"gulp-plumber": "^1.0.1",
2928
"gulp-rename": "^1.2.2",
3029
"gulp-sass": "^2.0.1",

0 commit comments

Comments
 (0)