Skip to content

tether-drop does not work with v2.0 #1446

Open
@ericyd

Description

Summary

tether-drop library does not work with v2.0, but no breaking changes were announced in the release notes.

Technically tether-drop is a separate lib and it's compatibility is not your concern, but I'm opening an issue here for two reasons

  1. tether-drop seems entirely abandoned, whereas this lib has at least a little recent activity
  2. The documentation for Tether references tether-drop liberally, and I imagine a new user of this lib would be a little confused at the incompatibility

Technical

  1. Drop relies on Tether.Utils (reference)
  2. Tether.Utils does not exist in the new version (reference)
  3. Documentation references tether-drop in many places, e.g.

Recommendation

This could probably be somewhat easily resolved by adding back a Tether.Utils declaration similar to the original.

However, please note that tether-drop also relies on extend, which appears to have been removed in v2.0.0.

If you're interested in a solution like this, let me know and I can try to open a PR. I'd probably just copy-paste the extend function from v1.4.7 since it's pretty small and self-contained.

Thanks for your time and energy 🙂

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions