Open
Description
Is there an existing issue for this?
- I have searched the existing issues
Kubernetes Version
N/A
Shipwright Version
v0.15
Current Behavior
The current unit tests - executed by make test
- make external network requests and/or require external binaries. I have found two test suites that are "guilty" of this behavior:
- Our git clone test suite.
- Our test suite for vulnerability scanning with trivy.
Expected Behavior
Unit tests should be bound to just the code itself, invoking mock interface implementations if specific behavior needs to be checked. Tests that require network requests and/or external binaries should be moved to the integration or e2e test suite.
Steps To Reproduce
- Run
make test
without Trivy installed locally - Run
make test
without SSH keys that are valid for git clone.
Anything else?
Potentially related to #1451
Metadata
Metadata
Assignees
Type
Projects
Status
No status