Skip to content

Commit 3c2fed7

Browse files
committed
Separate manifest list creation for commit-sha and release tags
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
1 parent 89a9bfa commit 3c2fed7

File tree

2 files changed

+24
-12
lines changed

2 files changed

+24
-12
lines changed

.github/workflows/golang.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ jobs:
5656
with:
5757
oidc-provider-name: nvgithub
5858
oidc-audience: ${{ secrets.OIDC_ARTIFACTORY_ENDPOINT }}
59+
cache: true
5960
- name: Check golang modules
6061
env:
6162
OIDC_USER: ${{ steps.jfrog.outputs.oidc-user }}
@@ -103,6 +104,7 @@ jobs:
103104
with:
104105
oidc-provider-name: nvgithub
105106
oidc-audience: ${{ secrets.OIDC_ARTIFACTORY_ENDPOINT }}
107+
cache: true
106108
- name: Run Coverage
107109
env:
108110
OIDC_USER: ${{ steps.jfrog.outputs.oidc-user }}
@@ -141,6 +143,7 @@ jobs:
141143
with:
142144
oidc-provider-name: nvgithub
143145
oidc-audience: ${{ secrets.OIDC_ARTIFACTORY_ENDPOINT }}
146+
cache: true
144147
- name: Run Build
145148
env:
146149
OIDC_USER: ${{ steps.jfrog.outputs.oidc-user }}

.github/workflows/image.yml

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ jobs:
7070
with:
7171
oidc-provider-name: nvgithub
7272
oidc-audience: ${{ secrets.OIDC_ARTIFACTORY_ENDPOINT }}
73+
cache: true
7374
- name: Build image
7475
env:
7576
IMAGE_NAME: ghcr.io/${LOWERCASE_REPO_OWNER}/k8s-nim-operator
@@ -129,6 +130,7 @@ jobs:
129130
with:
130131
oidc-provider-name: nvgithub
131132
oidc-audience: ${{ secrets.OIDC_ARTIFACTORY_ENDPOINT }}
133+
cache: true
132134
- name: Build image
133135
env:
134136
IMAGE_NAME: ghcr.io/${LOWERCASE_REPO_OWNER}/k8s-nim-operator
@@ -168,24 +170,31 @@ jobs:
168170
registry: ghcr.io
169171
username: ${{ github.actor }}
170172
password: ${{ secrets.GITHUB_TOKEN }}
171-
- name: Build Manifest
173+
# Always create/push the commit-SHA manifest
174+
- name: Build Manifest (commit SHA)
172175
env:
173176
OPERATOR_IMAGE_ARM: ghcr.io/${{ env.LOWERCASE_REPO_OWNER }}/k8s-nim-operator:${{ env.COMMIT_SHORT_SHA }}-arm64
174-
OPERATOR_IMAGE_AMD: ghcr.io/${{ env.LOWERCASE_REPO_OWNER}}/k8s-nim-operator:${{ env.COMMIT_SHORT_SHA }}-amd64
177+
OPERATOR_IMAGE_AMD: ghcr.io/${{ env.LOWERCASE_REPO_OWNER }}/k8s-nim-operator:${{ env.COMMIT_SHORT_SHA }}-amd64
175178
OPERATOR_MULTIARCH_IMAGE: ghcr.io/${{ env.LOWERCASE_REPO_OWNER }}/k8s-nim-operator:${{ env.COMMIT_SHORT_SHA }}
176-
OPERATOR_MULTIARCH_IMAGE_BRANCH: ghcr.io/${{ env.LOWERCASE_REPO_OWNER }}/k8s-nim-operator:${{ env.BRANCH }}
177179
run: |
178180
docker manifest create \
179-
${OPERATOR_MULTIARCH_IMAGE} \
180-
${OPERATOR_IMAGE_AMD} \
181-
${OPERATOR_IMAGE_ARM}
182-
docker manifest push ${OPERATOR_MULTIARCH_IMAGE}
183-
181+
"${OPERATOR_MULTIARCH_IMAGE}" \
182+
"${OPERATOR_IMAGE_AMD}" \
183+
"${OPERATOR_IMAGE_ARM}"
184+
docker manifest push "${OPERATOR_MULTIARCH_IMAGE}"
185+
# Only create/push the branch-name manifest on main or release-* branches
186+
- name: Build Manifest (branch tag)
187+
if: ${{ github.ref_name == 'main' || startsWith(github.ref_name, 'release-') }}
188+
env:
189+
OPERATOR_IMAGE_ARM: ghcr.io/${{ env.LOWERCASE_REPO_OWNER }}/k8s-nim-operator:${{ env.COMMIT_SHORT_SHA }}-arm64
190+
OPERATOR_IMAGE_AMD: ghcr.io/${{ env.LOWERCASE_REPO_OWNER }}/k8s-nim-operator:${{ env.COMMIT_SHORT_SHA }}-amd64
191+
OPERATOR_MULTIARCH_IMAGE_BRANCH: ghcr.io/${{ env.LOWERCASE_REPO_OWNER }}/k8s-nim-operator:${{ env.BRANCH }}
192+
run: |
184193
docker manifest create \
185-
${OPERATOR_MULTIARCH_IMAGE_BRANCH} \
186-
${OPERATOR_IMAGE_AMD} \
187-
${OPERATOR_IMAGE_ARM}
188-
docker manifest push ${OPERATOR_MULTIARCH_IMAGE_BRANCH}
194+
"${OPERATOR_MULTIARCH_IMAGE_BRANCH}" \
195+
"${OPERATOR_IMAGE_AMD}" \
196+
"${OPERATOR_IMAGE_ARM}"
197+
docker manifest push "${OPERATOR_MULTIARCH_IMAGE_BRANCH}"
189198
build-bundle:
190199
runs-on: ubuntu-latest
191200
needs: build-image-multi-arch

0 commit comments

Comments
 (0)