Phase 9: Adapter hardening — Pdeathsig, callback handlers, SSH stub #16
shivamstaqAnnotations
10 errors and 3 warnings
|
lint
issues found
|
|
lint:
cmd/symphony/main.go#L359
field healthy is unused (unused)
|
|
lint:
internal/orchestrator/orchestrator.go#L305
SA4010: this result of append is never used, except maybe in other appends (staticcheck)
|
|
lint:
internal/github/source.go#L147
S1016: should convert p (type PRRefRaw) to NormalizedPR instead of using struct literal (staticcheck)
|
|
lint:
internal/github/source.go#L144
S1016: should convert s (type ChildRefRaw) to NormalizedChild instead of using struct literal (staticcheck)
|
|
lint:
internal/github/source.go#L141
S1016: should convert b (type BlockerRefRaw) to NormalizedBlocker instead of using struct literal (staticcheck)
|
|
lint:
internal/orchestrator/worker.go#L94
Error return value of `adapterClient.Close` is not checked (errcheck)
|
|
lint:
cmd/symphony/main.go#L430
Error return value of `resp.Body.Close` is not checked (errcheck)
|
|
lint:
cmd/symphony/main.go#L306
Error return value of `watcher.Close` is not checked (errcheck)
|
|
lint:
cmd/symphony/main.go#L120
Error return value of `store.Close` is not checked (errcheck)
|
|
lint
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-go@v5, golangci/golangci-lint-action@v7. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
test
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-go@v5. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
docker-build
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|