Skip to content

Add section for users to edit their profile #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Add section for users to edit their profile #517

wants to merge 13 commits into from

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Apr 23, 2025 •
edited
Loading

Closes #473

Todo

  • Update session when display name is changed
  • Extract every form into its own individually testable component

@codecov Codecov
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 36.92308% with 82 lines in your changes missing coverage. Please review.

Project coverage is 70.36%. Comparing base (4c9ce68) to head (0b19f20).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
app/routes/profile.tsx 0.00% 53 Missing and 1 partial ⚠️
app/users/UsersService.server.ts 35.48% 18 Missing and 2 partials ⚠️
app/utils/form.server.ts 60.00% 0 Missing and 4 partials ⚠️
app/common/Layout.tsx 85.71% 0 Missing and 1 partial ⚠️
app/routes/servers/manage-servers.tsx 0.00% 1 Missing ⚠️
app/routes/users/UserServers.tsx 0.00% 0 Missing and 1 partial ⚠️
app/routes/users/manage-users.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
- Coverage   72.53%   70.36%   -2.17%     
==========================================
  Files          62       65       +3     
  Lines        2086     2190     +104     
  Branches      324      328       +4     
==========================================
+ Hits         1513     1541      +28     
- Misses        250      322      +72     
- Partials      323      327       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@acelaya acelaya force-pushed the feature/edit-profile branch from 8bd1036 to b232548 Compare April 25, 2025 07:02
@acelaya acelaya force-pushed the feature/edit-profile branch from b232548 to 6a00e19 Compare April 26, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to edit their own profile
1 participant
@acelaya