Add one more env-specific API test

Author: acelaya

module/Rest/test-api/Middleware/CorsTest.php

@@ -7,7 +7,9 @@
 use GuzzleHttp\RequestOptions;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Test;
+use Shlinkio\Shlink\Core\Config\EnvVars;
 use Shlinkio\Shlink\TestUtils\ApiTest\ApiTestCase;
+use ShlinkioApiTest\Shlink\Rest\Utils\WithEnvVars;
 
 class CorsTest extends ApiTestCase
 {
@@ -72,4 +74,20 @@ public static function providePreflightEndpoints(): iterable
         yield 'tags route' => ['/tags', 'GET,DELETE,PUT'];
         yield 'health route' => ['/health', 'GET'];
     }
+
+    #[Test, WithEnvVars([
+        EnvVars::CORS_MAX_AGE->value => 5000,
+        EnvVars::CORS_ALLOW_CREDENTIALS->value => true,
+        EnvVars::CORS_ALLOW_ORIGIN->value => 'example.com,localhost:8000',
+    ])]
+    public function parametersCanBeCustomized(): void
+    {
+        $resp = $this->callApiWithKey(self::METHOD_OPTIONS, '/short-urls', [
+            RequestOptions::HEADERS => ['Origin' => 'example.com'],
+        ]);
+
+        self::assertEquals('5000', $resp->getHeaderLine('Access-Control-Max-Age'));
+        self::assertEquals('example.com', $resp->getHeaderLine('Access-Control-Allow-Origin'));
+        self::assertEquals('true', $resp->getHeaderLine('Access-Control-Allow-Credentials'));
+    }
 }

module/Rest/test-api/Utils/ApiTestsExtension.php

@@ -8,6 +8,7 @@
 use PHPUnit\Runner\Extension\Facade;
 use PHPUnit\Runner\Extension\ParameterCollection;
 use PHPUnit\TextUI\Configuration\Configuration;
+use Symfony\Component\Process\Process;
 
 class ApiTestsExtension implements Extension
 {
@@ -16,4 +17,9 @@ public function bootstrap(Configuration $configuration, Facade $facade, Paramete
         $facade->registerSubscriber(new EnvSpecificTestListener());
         $facade->registerSubscriber(new CleanDynamicEnvVarsTestListener());
     }
+
+    public static function restartRRServer(): void
+    {
+        (new Process(['bin/rr', 'reset', '-c=config/roadrunner/.rr.test.yml']))->mustRun();
+    }
 }

module/Rest/test-api/Utils/CleanDynamicEnvVarsTestListener.php

@@ -6,7 +6,6 @@
 
 use PHPUnit\Event\Test\Finished;
 use PHPUnit\Event\Test\FinishedSubscriber;
-use Symfony\Component\Process\Process;
 
 use function file_exists;
 use function unlink;
@@ -23,7 +22,7 @@ public function notify(Finished $event): void
         if (file_exists(DYNAMIC_ENV_VARS_FILE)) {
             unlink(DYNAMIC_ENV_VARS_FILE);
             // Restart server again so that it removes the env vars from the file that has just been deleted
-            (new Process(['bin/rr', 'reset', '-c=config/roadrunner/.rr.test.yml']))->mustRun();
+            ApiTestsExtension::restartRRServer();
         }
     }
 }

module/Rest/test-api/Utils/EnvSpecificTestListener.php

@@ -4,10 +4,10 @@
 
 namespace ShlinkioApiTest\Shlink\Rest\Utils;
 
+use PHPUnit\Event\Code\TestMethod;
 use PHPUnit\Event\Test\PreparationStarted;
 use PHPUnit\Event\Test\PreparationStartedSubscriber;
 use ReflectionMethod;
-use Symfony\Component\Process\Process;
 use Webimpress\SafeWriter\FileWriter;
 
 use function sprintf;
@@ -24,6 +24,10 @@ class EnvSpecificTestListener implements PreparationStartedSubscriber
     public function notify(PreparationStarted $event): void
     {
         $test = $event->test();
+        if (! ($test instanceof TestMethod)) {
+            return;
+        }
+
         $className = $test->className();
         $methodName = $test->methodName();
 
@@ -35,7 +39,7 @@ public function notify(PreparationStarted $event): void
             /** @var WithEnvVars $withEnvVars */
             $withEnvVars = $attributes[0]->newInstance();
             $this->createDynamicEnvVarsFile($withEnvVars->envVars);
-            $this->restartServer();
+            ApiTestsExtension::restartRRServer();
         }
     }
 
@@ -53,9 +57,4 @@ private function createDynamicEnvVarsFile(array $envVars): void
 
         FileWriter::writeFile(DYNAMIC_ENV_VARS_FILE, $content);
     }
-
-    private function restartServer(): void
-    {
-        (new Process(['bin/rr', 'reset', '-c=config/roadrunner/.rr.test.yml']))->mustRun();
-    }
 }