Skip to content

Commit a65c5c3

Browse files
authored
Merge pull request #2560 from acelaya-forks/pie
Install compatible extensions in dev docker images with pie
2 parents cb8ba5d + 6eb9419 commit a65c5c3

File tree

4 files changed

+27
-33
lines changed

4 files changed

+27
-33
lines changed

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ WORKDIR /etc/shlink
1515

1616
# Install required PHP extensions
1717
RUN \
18-
# Temp install dev dependencies needed to compile the extensions
18+
# Temp install dev dependencies needed to compile the extensions \
1919
apk add --no-cache --virtual .dev-deps sqlite-dev postgresql-dev icu-dev libzip-dev zlib-dev linux-headers && \
2020
docker-php-ext-install -j"$(nproc)" pdo_mysql pdo_pgsql intl calendar sockets bcmath zip && \
2121
apk add --no-cache sqlite-libs && \
2222
docker-php-ext-install -j"$(nproc)" pdo_sqlite && \
23-
# Remove temp dev extensions, and install prod equivalents that are required at runtime
23+
# Remove temp dev extensions, and install prod equivalents that are required at runtime \
2424
apk del .dev-deps && \
2525
apk add --no-cache postgresql icu libzip libpng
2626

data/infra/frankenphp.Dockerfile

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,24 +21,25 @@ RUN docker-php-ext-install pdo_sqlite
2121
RUN apk add --no-cache icu-dev
2222
RUN docker-php-ext-install intl
2323

24-
RUN apk add --no-cache libzip-dev zlib-dev
25-
RUN docker-php-ext-install zip
26-
2724
RUN apk add --no-cache postgresql-dev
2825
RUN docker-php-ext-install pdo_pgsql
2926

30-
RUN apk add --no-cache --virtual .phpize-deps $PHPIZE_DEPS linux-headers && \
27+
COPY --from=ghcr.io/php/pie:bin /pie /usr/bin/pie
28+
RUN apk add --no-cache libzip-dev zlib-dev && \
29+
apk add --no-cache --virtual .phpize-deps $PHPIZE_DEPS linux-headers && \
3130
docker-php-ext-install sockets && \
31+
pie install xdebug/xdebug && \
32+
pie install pecl/zip && \
3233
apk del .phpize-deps
3334
RUN docker-php-ext-install bcmath
3435

35-
# Install xdebug and sqlsrv driver
36+
# Install sqlsrv driver
3637
RUN apk add --update linux-headers && \
3738
wget https://download.microsoft.com/download/${MS_ODBC_DOWNLOAD}/msodbcsql${MS_ODBC_SQL_VERSION}-1_amd64.apk && \
3839
apk add --allow-untrusted msodbcsql${MS_ODBC_SQL_VERSION}-1_amd64.apk && \
3940
apk add --no-cache --virtual .phpize-deps $PHPIZE_DEPS unixodbc-dev && \
40-
pecl install pdo_sqlsrv-${PDO_SQLSRV_VERSION} xdebug && \
41-
docker-php-ext-enable pdo_sqlsrv xdebug && \
41+
pecl install pdo_sqlsrv-${PDO_SQLSRV_VERSION} && \
42+
docker-php-ext-enable pdo_sqlsrv && \
4243
apk del .phpize-deps && \
4344
rm msodbcsql${MS_ODBC_SQL_VERSION}-1_amd64.apk
4445

data/infra/php.Dockerfile

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -22,34 +22,26 @@ RUN docker-php-ext-install pdo_sqlite
2222
RUN apk add --no-cache icu-dev
2323
RUN docker-php-ext-install intl
2424

25-
RUN apk add --no-cache libzip-dev zlib-dev
26-
RUN docker-php-ext-install zip
27-
2825
RUN apk add --no-cache postgresql-dev
2926
RUN docker-php-ext-install pdo_pgsql
3027

31-
RUN apk add --no-cache --virtual .phpize-deps $PHPIZE_DEPS linux-headers && \
28+
COPY --from=ghcr.io/php/pie:bin /pie /usr/bin/pie
29+
RUN apk add --no-cache libzip-dev zlib-dev && \
30+
apk add --no-cache --virtual .phpize-deps $PHPIZE_DEPS linux-headers && \
3231
docker-php-ext-install sockets && \
32+
pie install xdebug/xdebug && \
33+
pie install pecl/zip && \
34+
pie install apcu/apcu && \
3335
apk del .phpize-deps
3436
RUN docker-php-ext-install bcmath
3537

36-
# Install APCu extension
37-
ADD https://pecl.php.net/get/apcu-$APCU_VERSION.tgz /tmp/apcu.tar.gz
38-
RUN mkdir -p /usr/src/php/ext/apcu \
39-
&& tar xf /tmp/apcu.tar.gz -C /usr/src/php/ext/apcu --strip-components=1 \
40-
&& docker-php-ext-configure apcu \
41-
&& docker-php-ext-install apcu \
42-
&& rm /tmp/apcu.tar.gz \
43-
&& rm /usr/local/etc/php/conf.d/docker-php-ext-apcu.ini \
44-
&& echo extension=apcu.so > /usr/local/etc/php/conf.d/20-php-ext-apcu.ini
45-
46-
# Install xdebug and sqlsrv driver
38+
# Install sqlsrv driver
4739
RUN apk add --update linux-headers && \
4840
wget https://download.microsoft.com/download/${MS_ODBC_DOWNLOAD}/msodbcsql${MS_ODBC_SQL_VERSION}-1_amd64.apk && \
4941
apk add --allow-untrusted msodbcsql${MS_ODBC_SQL_VERSION}-1_amd64.apk && \
5042
apk add --no-cache --virtual .phpize-deps $PHPIZE_DEPS unixodbc-dev && \
51-
pecl install pdo_sqlsrv-${PDO_SQLSRV_VERSION} xdebug && \
52-
docker-php-ext-enable pdo_sqlsrv xdebug && \
43+
pecl install pdo_sqlsrv-${PDO_SQLSRV_VERSION} && \
44+
docker-php-ext-enable pdo_sqlsrv && \
5345
apk del .phpize-deps && \
5446
rm msodbcsql${MS_ODBC_SQL_VERSION}-1_amd64.apk
5547

data/infra/roadrunner.Dockerfile

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,24 +21,25 @@ RUN docker-php-ext-install pdo_sqlite
2121
RUN apk add --no-cache icu-dev
2222
RUN docker-php-ext-install intl
2323

24-
RUN apk add --no-cache libzip-dev zlib-dev
25-
RUN docker-php-ext-install zip
26-
2724
RUN apk add --no-cache postgresql-dev
2825
RUN docker-php-ext-install pdo_pgsql
2926

30-
RUN apk add --no-cache --virtual .phpize-deps $PHPIZE_DEPS linux-headers && \
27+
COPY --from=ghcr.io/php/pie:bin /pie /usr/bin/pie
28+
RUN apk add --no-cache libzip-dev zlib-dev && \
29+
apk add --no-cache --virtual .phpize-deps $PHPIZE_DEPS linux-headers && \
3130
docker-php-ext-install sockets && \
31+
pie install xdebug/xdebug && \
32+
pie install pecl/zip && \
3233
apk del .phpize-deps
3334
RUN docker-php-ext-install bcmath
3435

35-
# Install xdebug and sqlsrv driver
36+
# Install sqlsrv driver
3637
RUN apk add --update linux-headers && \
3738
wget https://download.microsoft.com/download/${MS_ODBC_DOWNLOAD}/msodbcsql${MS_ODBC_SQL_VERSION}-1_amd64.apk && \
3839
apk add --allow-untrusted msodbcsql${MS_ODBC_SQL_VERSION}-1_amd64.apk && \
3940
apk add --no-cache --virtual .phpize-deps $PHPIZE_DEPS unixodbc-dev && \
40-
pecl install pdo_sqlsrv-${PDO_SQLSRV_VERSION} xdebug && \
41-
docker-php-ext-enable pdo_sqlsrv xdebug && \
41+
pecl install pdo_sqlsrv-${PDO_SQLSRV_VERSION} && \
42+
docker-php-ext-enable pdo_sqlsrv && \
4243
apk del .phpize-deps && \
4344
rm msodbcsql${MS_ODBC_SQL_VERSION}-1_amd64.apk
4445

0 commit comments

Comments
 (0)