Specifying percentage for "all" breaks if both FORTDIR and LOCFORTDIR have fortunes

[ralismark]

Demonstration:

$ fortune 70% all
fortune: probabilities sum to 140%!

This seems to be because FORTDIR and LOCFORTDIR both get separately added with the specified pecentage, instead of sharing the 70% between the two, so it effectively interprets it as fortune 70% <locfortdir> 70% <fortdir>.

I don't think fixing this is as simple as halving the percentage, since if the two directories have different numbers of fortunes, each fortunes in FORTDIR would have a different probability of showing up compared to ones in LOCFORTDIR. This would differ from what I'd expect if all the fortunes were in the same directory, where e.g. fortune 70% ./dir would still mean every fortune in dir has a roughly equal chance of appearing.

[shlomif]

Thanks for the report. I reproduced the issue.

[shlomif]

I think I've made a lot of progress with the percentage thing, and added many system tests ( tests/*.t ) in the process. but many usecases are still broken:

[shlomif@telaviv1 ~]$ fortune 70% all                
fortune: no place to put residual probability (70%)
[shlomif@telaviv1 ~]$ fortune 100% all
Albrecht's Law:
        Social innovations tend to the level of minimum tolerable well-being.
[shlomif@telaviv1 ~]$ fortune 70% all 30% shlomif-fav
fortune: no place to put residual probability (30%)
[shlomif@telaviv1 ~]$ fortune 100% shlomif-fav       
08/25/2007 - The Windows Genuine Advantage servers went down worldwide,
marking any Windows machines as pirated during Microsoft's server outage.
Meanwhile, the Linux Genuine Advantage™ activation server was up the whole
time. Truly another victory for Open Source software! Microsoft, contact us if
you'd like to license Linux Genuine Advantage™, we'd love to enter into a
lucrative licensing agreement. With the money you save, you could put the WGA
programmers onto other tasks, like improving Vista!

02/03/2007 - The Linux Genuine Advantage™ crack is spreading! Someone uploaded
it to The Pirate Bay! Looks like it's time to get more involved in Swedish
politics from across the globe!

02/02/2007 - Linux Genuine Advantage™ has been cracked by computer hackers!
Rather than improving our software, we'll be sending our team of intimidating
lawyers to pay them a visit.

    -- Linux Genuine Advantage ( http://www.linuxgenuineadvantage.org/ )
[shlomif@telaviv1 ~]$ fortune all
Hokey religions and ancient weapons are no substitute for a good blaster at
your side.
                -- Han Solo
[shlomif@telaviv1 ~]$