Skip to content

Commit 8e43671

Browse files
committed
Run end to end tests in paralell using Ginkgo
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
1 parent 625367d commit 8e43671

1 file changed

Lines changed: 2 additions & 41 deletions

File tree

.github/workflows/ci-pr-checks.yaml

Lines changed: 2 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Matrix jobs (e2e-image-common, e2e-image-router, e2e-router) are each
1+
# Matrix jobs (e2e-image-common, e2e-image-router) are each
22
# followed by a *-status job that aggregates their result, since GitHub
33
# required status checks cannot reference individual matrix legs.
44
name: CI - Test
@@ -348,29 +348,6 @@ jobs:
348348
if: ${{ needs.check-changes.outputs.src == 'true' }}
349349
runs-on: ubuntu-latest
350350
timeout-minutes: 45
351-
strategy:
352-
fail-fast: false
353-
matrix:
354-
suite:
355-
- name: pd
356-
label-filter: "!Disruptive && !Extended && !SharedStorage && !Metrics"
357-
needs-renderer: "false"
358-
- name: pd-shared-storage-deprecated
359-
label-filter: "SharedStorage && DeprecatedPD"
360-
needs-renderer: "false"
361-
- name: pd-shared-storage-disagg
362-
label-filter: "SharedStorage && Disagg"
363-
needs-renderer: "false"
364-
- name: pd-metrics
365-
label-filter: "Metrics"
366-
needs-renderer: "false"
367-
- name: extended
368-
label-filter: "Extended"
369-
needs-renderer: "true"
370-
- name: disruption
371-
label-filter: "Disruptive"
372-
needs-renderer: "false"
373-
name: e2e-router (${{ matrix.suite.name }})
374351
steps:
375352
- name: Checkout source
376353
uses: actions/checkout@v7
@@ -404,7 +381,6 @@ jobs:
404381
path: ${{ runner.temp }}/e2e-images
405382

406383
- name: Download renderer image
407-
if: ${{ matrix.suite.needs-renderer == 'true' }}
408384
uses: actions/download-artifact@v8
409385
with:
410386
name: e2e-image-renderer
@@ -417,26 +393,11 @@ jobs:
417393
docker load --input "$image"
418394
done
419395
420-
- name: Run e2e-router (${{ matrix.suite.name }})
396+
- name: Run e2e-router
421397
shell: bash
422398
env:
423399
GO_MOD_CACHE_VOL: ${{ steps.e2e-setup.outputs.go-mod-cache }}
424400
GO_BUILD_CACHE_VOL: ${{ steps.e2e-setup.outputs.go-build-cache }}
425-
E2E_LABEL_FILTER: ${{ matrix.suite.label-filter }}
426-
LOAD_VLLM_RENDER_IMAGE: ${{ matrix.suite.needs-renderer }}
427401
PULL_VLLM_RENDER_IMAGE: "false"
428402
HF_TOKEN: ${{ secrets.HF_TOKEN }}
429403
run: make test-e2e-run
430-
431-
e2e-router-status:
432-
needs: e2e-router
433-
if: always()
434-
runs-on: ubuntu-latest
435-
steps:
436-
- name: Check e2e-router result
437-
run: |
438-
result="${{ needs.e2e-router.result }}"
439-
if [[ "$result" != "success" && "$result" != "skipped" ]]; then
440-
echo "::error::e2e-router failed for at least one matrix suite"
441-
exit 1
442-
fi

0 commit comments

Comments
 (0)