-
-
Notifications
You must be signed in to change notification settings - Fork 911
Open
Labels
bugThings that aren't working right in the library.Things that aren't working right in the library.
Description
Describe the bug
When using the sl-tab-group in angular and adding a new tab dynamically, which should be directly active, the new tab panel content is not shown. Instead there is no tab panel shown at all.
To Reproduce
Steps to reproduce the behavior:
- Go to this stackblitz
- Click on sl-button, which adds a new active tab
- See the problem of no panel content is shown at all
Screenshots
Browser / OS
- OS: all
- Browser: all
- Browser version:
Additional information
This problem seems to be only appearing with angular, because it handles some timings / lifecycles different than the other frameworks (like vue and react)
The caches of the tab-panels and tabs in the tab-group is done e.g. on slotchange. But for angular this is not enough. For this bug, the slotchange fires too late.
This bug can be fixed by no longer using a cache for the panels and tabs but just use e.g. the @queryAssignedElements of lit
I would be willing to create a PR for this bug
Metadata
Metadata
Assignees
Labels
bugThings that aren't working right in the library.Things that aren't working right in the library.

