Skip to content

<sl-icon> Iconoir documentation example broken after Iconoir v7 update #2511

@davidcromianski-dev

Description

@davidcromianski-dev

Since Iconoir v7.0.0, the CDN path for icons changed, causing the Shoelace documentation example for the Iconoir library to break.

  • Old path:
    https://cdn.jsdelivr.net/gh/lucaburgio/iconoir@latest/icons/${name}.svg
  • New path:
    https://cdn.jsdelivr.net/gh/lucaburgio/iconoir@latest/icons/regular/${name}.svg

To Reproduce

Steps to reproduce:

  1. Visit Shoelace Icon Component — Iconoir example
  2. Observe that the icon does not load

Expected behavior

The example should load the Iconoir icons using the updated CDN path.

Suggested fix

  1. Update the CDN path in the documentation example to the new format.
  2. Update the example icon reference:
    <!-- Current (invalid) -->
    <sl-icon library="iconoir" name="check-circled-outline"></sl-icon>
    
    <!-- Suggested -->
    <sl-icon library="iconoir" name="check-circle"></sl-icon>

Note: check-circled-outline no longer exists in Iconoir v7.

Screenshots

Before

Image

After

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugThings that aren't working right in the library.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions