Skip to content

Commit 4f9f4c1

Browse files
sebastienbeauchafique-delli
authored andcommitted
[REF] refactor code due to change in base module
1 parent c7b0732 commit 4f9f4c1

File tree

13 files changed

+21
-20
lines changed

13 files changed

+21
-20
lines changed

shopinvader_dropoff_site_edition/__manifest__.py renamed to shopinvader_delivery_pickup_public_edition/__manifest__.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
55

66
{
7-
"name": "Shopinvader Dropoff site Public Edition",
8-
"summary": "Shopinvader Dropoff site Public Edition",
7+
"name": "Shopinvader Pickup Public Edition",
8+
"summary": "Shopinvader Pickup Public Edition",
99
"version": "10.0.0.0.0",
1010
"category": "e-commerce",
1111
"website": "https://akretion.com",
@@ -14,7 +14,7 @@
1414
"application": False,
1515
"installable": True,
1616
"external_dependencies": {"python": [], "bin": []},
17-
"depends": ["shopinvader_dropoff_site"],
17+
"depends": ["shopinvader_delivery_pickup"],
1818
"data": ["views/delivery_carrier_view.xml"],
1919
"demo": [],
2020
"qweb": [],

shopinvader_dropoff_site_edition/services/cart.py renamed to shopinvader_delivery_pickup_public_edition/services/cart.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
class CartService(Component):
1313
_inherit = "shopinvader.cart.service"
1414

15-
def set_public_dropoff_site(self, **params):
15+
def set_public_delivery_pickup(self, **params):
1616
"""
1717
This service will create/update apply the given dropoffsite
1818
to the current cart
@@ -23,12 +23,12 @@ def set_public_dropoff_site(self, **params):
2323
if not cart:
2424
raise UserError(_("There is not cart"))
2525
else:
26-
self._add_update_dropoff_site(cart, params)
27-
self._set_dropoff_site(cart, params["code"])
26+
dropoff_site = self._add_update_dropoff_site(cart, params)
27+
self._set_delivery_pickup(cart, dropoff_site.id)
2828
return self._to_json(cart)
2929

3030
# Validator
31-
def _validator_set_public_dropoff_site(self):
31+
def _validator_set_public_delivery_pickup(self):
3232
return {
3333
"code": {"type": "string", "required": True},
3434
"name": {"type": "string", "required": True},
@@ -84,3 +84,4 @@ def _add_update_dropoff_site(self, cart, dropoff_site):
8484
dropoff_site.write(vals)
8585
else:
8686
dropoff_site = dropoff_site_obj.create(vals)
87+
return dropoff_site
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# -*- coding: utf-8 -*-
2+
3+
from . import test_pickup

shopinvader_dropoff_site_edition/tests/test_dropoff_site.py renamed to shopinvader_delivery_pickup_public_edition/tests/test_pickup.py

+10-10
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
)
99

1010

11-
class DropOffSiteCase(CommonCarrierCase):
11+
class PickupCase(CommonCarrierCase):
1212
def setUp(self):
13-
super(DropOffSiteCase, self).setUp()
13+
super(PickupCase, self).setUp()
1414
self.final_partner = self.cart.partner_shipping_id
1515
self.poste_carrier.write(
1616
{
@@ -19,11 +19,11 @@ def setUp(self):
1919
}
2020
)
2121
self._set_carrier(self.poste_carrier)
22-
self._set_dropoff_site(ref="foo", name="Bar")
22+
self._set_pickup(ref="foo", name="Bar")
2323

24-
def _set_dropoff_site(self, ref, name):
24+
def _set_pickup(self, ref, name):
2525
self.service.dispatch(
26-
"set_public_dropoff_site",
26+
"set_public_delivery_pickup",
2727
params={
2828
"code": ref,
2929
"name": name,
@@ -34,27 +34,27 @@ def _set_dropoff_site(self, ref, name):
3434
},
3535
)
3636

37-
def test_setting_dropoff_site(self):
37+
def test_setting_pickup(self):
3838
shipping = self.cart.partner_shipping_id
3939
self.assertEqual(shipping.ref, "foo")
4040
self.assertEqual(shipping.name, "Bar")
4141
self.assertEqual(
4242
self.cart.final_shipping_partner_id, self.final_partner
4343
)
4444

45-
def test_updating_dropoff_site(self):
45+
def test_updating_pickup(self):
4646
shipping = self.cart.partner_shipping_id
47-
self._set_dropoff_site(ref="foo", name="Updated")
47+
self._set_pickup(ref="foo", name="Updated")
4848
self.assertEqual(self.cart.partner_shipping_id, shipping)
4949
self.assertEqual(shipping.ref, "foo")
5050
self.assertEqual(shipping.name, "Updated")
5151
self.assertEqual(
5252
self.cart.final_shipping_partner_id, self.final_partner
5353
)
5454

55-
def test_changing_dropoff_site(self):
55+
def test_changing_pickup(self):
5656
previous_shipping = self.cart.partner_shipping_id
57-
self._set_dropoff_site(ref="foo2", name="Bar2")
57+
self._set_pickup(ref="foo2", name="Bar2")
5858
self.assertNotEqual(self.cart.partner_shipping_id, previous_shipping)
5959
shipping = self.cart.partner_shipping_id
6060
self.assertEqual(shipping.ref, "foo2")

shopinvader_dropoff_site_edition/tests/__init__.py

-3
This file was deleted.

0 commit comments

Comments
 (0)