Merge pull request #2953 in SW/shopware from sw-12505/5.0/fix-debit-payment-validation to 5.0

Marcel Schmäing · Marcel Schmäing · commit 945009d8811e · 2015-09-11T09:56:44.000+02:00
* commit '262ac8d1300c80995a8becd458c2e215e4946172':
  SW-12505 - Fix debut validation
diff --git a/engine/Shopware/Plugins/Default/Core/PaymentMethods/Components/DebitPaymentMethod.php b/engine/Shopware/Plugins/Default/Core/PaymentMethods/Components/DebitPaymentMethod.php
@@ -67,7 +67,7 @@ public function validate($paymentData)
                 "sErrorMessages" => $sErrorMessages
             );
         } else {
-            return true;
+            return array();
         }
     }
 
diff --git a/tests/Shopware/Tests/Plugins/Core/PaymentMethods/Components/DebitPaymentMethodTest.php b/tests/Shopware/Tests/Plugins/Core/PaymentMethods/Components/DebitPaymentMethodTest.php
@@ -111,7 +111,7 @@ public function testValidateCorrectData()
         ];
 
         $validationResult = self::$debitPaymentMethod->validate($data);
-        $this->assertTrue($validationResult);
+        $this->assertEmpty($validationResult);
     }
 
     public function testCreatePaymentInstanceWithNoPaymentData()

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ public function validate($paymentData)`
`67`	`67`	`"sErrorMessages" => $sErrorMessages`
`68`	`68`	`);`
`69`	`69`	`} else {`
`70`		`- return true;`
	`70`	`+ return array();`
`71`	`71`	`}`
`72`	`72`	`}`
`73`	`73`
Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ public function testValidateCorrectData()`
`111`	`111`	`];`
`112`	`112`
`113`	`113`	`$validationResult = self::$debitPaymentMethod->validate($data);`
`114`		`- $this->assertTrue($validationResult);`
	`114`	`+ $this->assertEmpty($validationResult);`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`public function testCreatePaymentInstanceWithNoPaymentData()`