fix: Remove v character from version tag

mitelg · mitelg · commit b025f04ba7b2 · 2023-09-25T14:05:08.000+02:00
diff --git a/engine/Shopware/Plugins/Default/Backend/SwagUpdate/Components/UpdateCheck.php b/engine/Shopware/Plugins/Default/Backend/SwagUpdate/Components/UpdateCheck.php
@@ -134,7 +134,7 @@ private function createVersionFromGithubResponse(string $shopwareVersion, array
     private function getRelease(string $shopwareVersion, array $releaseInformation): array
     {
         foreach ($releaseInformation as $release) {
-            if (version_compare($shopwareVersion, $release['tag_name'], '>=')) {
+            if (version_compare($shopwareVersion, ltrim($release['tag_name'], 'v'), '>=')) {
                 continue;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ private function createVersionFromGithubResponse(string $shopwareVersion, array`
`134`	`134`	`private function getRelease(string $shopwareVersion, array $releaseInformation): array`
`135`	`135`	`{`
`136`	`136`	`foreach ($releaseInformation as $release) {`
`137`		`- if (version_compare($shopwareVersion, $release['tag_name'], '>=')) {`
	`137`	`+ if (version_compare($shopwareVersion, ltrim($release['tag_name'], 'v'), '>=')) {`
`138`	`138`	`continue;`
`139`	`139`	`}`
`140`	`140`